Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable publishing CoreCLR product binaries on GCC leg #33580

Merged
1 commit merged into from
Mar 14, 2020

Conversation

safern
Copy link
Member

@safern safern commented Mar 13, 2020

This fixes the segmentation fault failures on Linux x64 checked runs.

cc: @jkotas @am11 @AndyAyersMS

@am11
Copy link
Member

am11 commented Mar 13, 2020

Thanks @safern!
wondering why wasn't it get caught in the original PR and many build runs since. 🤔

@safern
Copy link
Member Author

safern commented Mar 13, 2020

wondering why wasn't it get caught in the original PR and many build runs since. 🤔

It is a timing issue. It depends on which build finishes and uploads the binaries first.

@AndyAyersMS
Copy link
Member

In my failing PR run the GCC build published about 2 minutes after the Clang build, so the GCC built assets were the ones that propagated. Failure mode was pretty cryptic.

As an aside, I wonder if this is something that could/should have produced an error message instead of a segv, presumably it was a native library load failure of some sort?

Seems like the same thing maybe could happen with the product build? Does the fix above stop all publishing from the GCC builds?

;; CLANG
2020-03-13T00:47:50.1915549Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz' to file container: '#/3640272/CoreCLRProduct_Linux_x64_checked'

2020-03-13T00:47:50.6261487Z Associated artifact 9329041 with build 557918

;; GCC
2020-03-13T00:50:30.1347541Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz' to file container: '#/3640272/CoreCLRProduct_Linux_x64_checked'

2020-03-13T00:50:32.0552290Z Associated artifact 9329041 with build 557918

@safern
Copy link
Member Author

safern commented Mar 13, 2020

Seems like the same thing maybe could happen with the product build? Does the fix above stop all publishing from the GCC builds?

The product build is defined in a separate yml which doesn't do any GCC builds, so it doesn't hit this issue. However, if it were the case it would fix it. If at some point we want for some reason to publish GCC assets, we should be able to just change the artifacts name so that they don't clash.

@ghost
Copy link

ghost commented Mar 14, 2020

Hello @safern!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit caa1f1b into dotnet:master Mar 14, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants