-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable publishing CoreCLR product binaries on GCC leg #33580
Conversation
Thanks @safern! |
It is a timing issue. It depends on which build finishes and uploads the binaries first. |
In my failing PR run the GCC build published about 2 minutes after the Clang build, so the GCC built assets were the ones that propagated. Failure mode was pretty cryptic. As an aside, I wonder if this is something that could/should have produced an error message instead of a segv, presumably it was a native library load failure of some sort? Seems like the same thing maybe could happen with the product build? Does the fix above stop all publishing from the GCC builds?
|
The product build is defined in a separate yml which doesn't do any GCC builds, so it doesn't hit this issue. However, if it were the case it would fix it. If at some point we want for some reason to publish GCC assets, we should be able to just change the artifacts name so that they don't clash. |
Hello @safern! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This fixes the segmentation fault failures on Linux x64 checked runs.
cc: @jkotas @am11 @AndyAyersMS