-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets #33562
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets #33562
Conversation
…312.3 - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3 - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3 - Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3 - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3 - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3 - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3 - Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3 - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3 - Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3 - Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3 - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
With any luck this should unblock official builds of runtime, which should unblock dotnet/extensions#3077. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
…ld 20200312.1 - System.Windows.Extensions.TestData - 5.0.0-beta.20162.1 - System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1 - System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1 - System.Net.TestData - 5.0.0-beta.20162.1 - System.IO.Packaging.TestData - 5.0.0-beta.20162.1 - System.IO.Compression.TestData - 5.0.0-beta.20162.1 - System.Drawing.Common.TestData - 5.0.0-beta.20162.1 - System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
Actually, there's still one more fix needed to unblock the builds of runtime - dotnet/arcade#5053 (comment) |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
CI is failing: .packages/microsoft.dotnet.apicompat/5.0.0-beta.20162.3/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.AppContext.add_FirstChanceException(System.EventHandler<System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs>)' does not exist in the reference but it does exist in the implementation. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
There were some changes to APICompat yesterday: dotnet/arcade@a5a6a98 @gugavaro could this impact what checks are triggered? CC @ericstj |
Also CC @safern @Anipik @ViktorHofer |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
This was expected to happen and I believe @gugavaro already has the needed changes ready. Could you please push them to this PR 😄 ? |
I believe we already merged them. Just need to rerun against tip. |
Yeah I saw that now: 4480bdb I'll re-run. |
eng/Versions.props
Outdated
<MicrosoftDotNetBuildTasksPackagingVersion>5.0.0-beta.20160.4</MicrosoftDotNetBuildTasksPackagingVersion> | ||
<MicrosoftDotNetRemoteExecutorVersion>5.0.0-beta.20160.4</MicrosoftDotNetRemoteExecutorVersion> | ||
<MicrosoftDotNetVersionToolsTasksVersion>5.0.0-beta.20160.4</MicrosoftDotNetVersionToolsTasksVersion> | ||
<MicrosoftDotNetApiCompatVersion>5.0.0-beta.20162.3</MicrosoftDotNetApiCompatVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it looks like this is downgrading the APIComat version? 😖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, just noticed that as well. It seems like maybe the .4 hasn't made it to the Latest channel and it is still in Validation. Will remove that change in a sec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird - the version in details.xml
was 5.0.0-beta.20160.4
, not 5.0.0-beta.20162.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it was because we updated it manually but we didn't update details.xml
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Fixed. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
I have not see it. Do you see the same failures in the rolling builds on master? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Yeah I see it. It seems like it started happening in: https://dev.azure.com/dnceng/public/_build/results?buildId=557918 Looking at the commits. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
It seems like there was only 2 commits from the last successful rolling build and the first one hitting the issue. Maybe it is this one: 84cf6a1 |
Or the GCC change. Is it possible that we are running the tests against GCC built binaries? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
The GCC leg should be build-only. No tests. |
I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either. |
This makes the GCC change more likely culprit. |
There is a crashdump here:
I believe it is build-only, but let me look at it. That could probably be the issue, probably the GCC leg is overriding the real coreclr artifacts. Looking now. |
Yeah. That is the issue from looking at the logs it is overriding the bin. /__w/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz I'll disable the publishing of the coreclr artifacts of GCC as it is not needed. I'll put up a PR to fix it in a sec. cc: @am11 |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
In my CI runs, we publish two sets of test native binaries -- looks like the GCC ones overwrite the CLANG ones...? Clang build
GCC build
|
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Yeah. It seems like it doesn't repro all the time because it depends which leg finishes first. I put up a PR to fix it: #33580 |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Failures are known and fixed: #33580 |
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
From https://github.com/dotnet/runtime-assets