Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Update dependencies from dotnet/arcade dotnet/runtime-assets #33562

Merged
merged 3 commits into from
Mar 14, 2020

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 13, 2020

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: d5e65fc1-96f8-47a5-f02e-08d75d5208ed
  • Build: 20200312.3
  • Date Produced: 3/12/2020 5:55 PM
  • Commit: 16d4350184cf362cd59807b589d1c93803025abc
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.XUnitExtensions -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.VersionTools.Tasks -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.ApiCompat -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Feed -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.Packaging -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.CodeAnalysis -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenAPI -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.RemoteExecutor -> 5.0.0-beta.20162.3
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.20162.3

From https://github.com/dotnet/runtime-assets

  • Subscription: 667d63c7-a2fc-425c-9020-08d76d41c6c3
  • Build: 20200312.1
  • Date Produced: 3/12/2020 9:25 AM
  • Commit: 9f99c474432904fadab3bcda4a65b20c1e990a6c
  • Branch: refs/heads/master
  • Updates:
    • System.Windows.Extensions.TestData -> 5.0.0-beta.20162.1
    • System.Security.Cryptography.X509Certificates.TestData -> 5.0.0-beta.20162.1
    • System.Private.Runtime.UnicodeData -> 5.0.0-beta.20162.1
    • System.Net.TestData -> 5.0.0-beta.20162.1
    • System.IO.Packaging.TestData -> 5.0.0-beta.20162.1
    • System.IO.Compression.TestData -> 5.0.0-beta.20162.1
    • System.Drawing.Common.TestData -> 5.0.0-beta.20162.1
    • System.ComponentModel.TypeConverter.TestData -> 5.0.0-beta.20162.1

…312.3

- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
@wtgodbe
Copy link
Member

wtgodbe commented Mar 13, 2020

With any luck this should unblock official builds of runtime, which should unblock dotnet/extensions#3077.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 13, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: runtime (Libraries Build OSX x64 Debug), runtime (Libraries Build Windows_NT net472 x86 Release), runtime (Mono LLVM Product Build Linux x64 release), runtime (Mono LLVM Product Build Linux x64 debug), runtime (Mono Product Build Linux x64 release), runtime (Mono Product Build Linux_musl x64 release), runtime (Mono Product Build Linux arm64 release), runtime (Mono Product Build Linux arm release), runtime (Mono Product Build Linux x64 debug), runtime (Mono Product Build Linux_musl x64 debug), runtime (Mono Product Build Linux arm64 debug), runtime (Mono Product Build Linux arm debug), runtime (Formatting Linux x64), runtime (CoreCLR Product Build Windows_NT arm64 release), runtime (CoreCLR Product Build Windows_NT x86 release), runtime (CoreCLR Product Build Windows_NT arm release), runtime (CoreCLR Product Build Windows_NT x64 release), runtime (CoreCLR Product Build Linux x64 release), runtime (CoreCLR Product Build Linux_musl arm64 release), runtime (CoreCLR Product Build Linux_musl x64 release), runtime (CoreCLR Product Build Linux arm64 release), runtime (CoreCLR Product Build Linux arm release), runtime (CoreCLR Product Build Windows_NT arm64 checked), runtime (CoreCLR GCC Product Build Linux x64 checked), runtime (CoreCLR Product Build Windows_NT x86 checked), runtime (CoreCLR Product Build Windows_NT arm checked), runtime (CoreCLR Product Build Windows_NT x64 checked), runtime (CoreCLR Product Build Linux x64 checked), runtime (CoreCLR Product Build Linux_musl x64 checked), runtime (CoreCLR Product Build Linux arm checked), runtime (CoreCLR Product Build Linux arm64 checked), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release), dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release), dotnet-runtime-perf (CoreCLR Product Build Linux x64 release), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime, dotnet-runtime-perf, runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…ld 20200312.1

- System.Windows.Extensions.TestData - 5.0.0-beta.20162.1
- System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1
- System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1
- System.Net.TestData - 5.0.0-beta.20162.1
- System.IO.Packaging.TestData - 5.0.0-beta.20162.1
- System.IO.Compression.TestData - 5.0.0-beta.20162.1
- System.Drawing.Common.TestData - 5.0.0-beta.20162.1
- System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from dotnet/arcade [master] Update dependencies from dotnet/arcade dotnet/runtime-assets Mar 13, 2020
@wtgodbe
Copy link
Member

wtgodbe commented Mar 13, 2020

Actually, there's still one more fix needed to unblock the builds of runtime - dotnet/arcade#5053 (comment)

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 13, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@GrabYourPitchforks
Copy link
Member

CI is failing:

.packages/microsoft.dotnet.apicompat/5.0.0-beta.20162.3/build/Microsoft.DotNet.ApiCompat.targets(143,5): error : MembersMustExist : Member 'System.AppContext.add_FirstChanceException(System.EventHandler<System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs>)' does not exist in the reference but it does exist in the implementation.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 13, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@wtgodbe
Copy link
Member

wtgodbe commented Mar 13, 2020

There were some changes to APICompat yesterday: dotnet/arcade@a5a6a98

@gugavaro could this impact what checks are triggered? CC @ericstj

@wtgodbe
Copy link
Member

wtgodbe commented Mar 13, 2020

Also CC @safern @Anipik @ViktorHofer

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug), runtime-live-build (Build Windows_NT x64 debug Mono_Libraries), runtime-live-build (Build Linux x64 debug RuntimeFlavor_Mono), runtime-live-build (Build Linux x64 debug Runtime_Release), runtime-live-build (Build Windows_NT x86 release Runtime_Debug), runtime-live-build (Build OSX x64 release Runtime_Debug), runtime-live-build
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Mar 13, 2020

This was expected to happen and I believe @gugavaro already has the needed changes ready. Could you please push them to this PR 😄 ?

@ericstj
Copy link
Member

ericstj commented Mar 13, 2020

I believe we already merged them. Just need to rerun against tip.

@safern
Copy link
Member

safern commented Mar 13, 2020

Yeah I saw that now: 4480bdb

I'll re-run.

@safern safern closed this Mar 13, 2020
@safern safern reopened this Mar 13, 2020
<MicrosoftDotNetBuildTasksPackagingVersion>5.0.0-beta.20160.4</MicrosoftDotNetBuildTasksPackagingVersion>
<MicrosoftDotNetRemoteExecutorVersion>5.0.0-beta.20160.4</MicrosoftDotNetRemoteExecutorVersion>
<MicrosoftDotNetVersionToolsTasksVersion>5.0.0-beta.20160.4</MicrosoftDotNetVersionToolsTasksVersion>
<MicrosoftDotNetApiCompatVersion>5.0.0-beta.20162.3</MicrosoftDotNetApiCompatVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this is downgrading the APIComat version? 😖

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just noticed that as well. It seems like maybe the .4 hasn't made it to the Latest channel and it is still in Validation. Will remove that change in a sec.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - the version in details.xml was 5.0.0-beta.20160.4, not 5.0.0-beta.20162.4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was because we updated it manually but we didn't update details.xml

4480bdb#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR63

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 13, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Build Linux_musl x64 Debug), runtime (Libraries Build Linux_musl arm64 Release), runtime (Libraries Build Linux arm64 Debug), runtime (Libraries Build Linux arm Release), runtime (Libraries Build WebAssembly wasm Debug), runtime (Libraries Build Linux x64 Debug), dotnet-runtime-perf (Libraries Build Linux x64 Release), runtime (Libraries Build Windows_NT arm Release), runtime (Libraries Build Windows_NT arm64 Release), runtime (Libraries Build Windows_NT x64 Debug), runtime (Libraries Build Windows_NT allConfigurations x64 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Release), runtime (Libraries Build Windows_NT x86 Debug), dotnet-runtime-perf (Libraries Build Windows_NT x64 Release), runtime (Libraries Build OSX x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Mar 13, 2020

Fixed.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 13, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Mar 13, 2020

@jaredpar @jkotas I'm seeing a lot of workitems failing on Linux x64 Checked runs for coreclr and Libraries tests fail with a segmentation fault. Is this known? If not I can go an open an issue to open investigation/discussion.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 13, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@jkotas
Copy link
Member

jkotas commented Mar 13, 2020

I have not see it. Do you see the same failures in the rolling builds on master?

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Mar 13, 2020

Yeah I see it. It seems like it started happening in: https://dev.azure.com/dnceng/public/_build/results?buildId=557918

Looking at the commits.

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Mar 13, 2020

It seems like there was only 2 commits from the last successful rolling build and the first one hitting the issue. Maybe it is this one: 84cf6a1

@jkotas
Copy link
Member

jkotas commented Mar 13, 2020

Or the GCC change. Is it possible that we are running the tests against GCC built binaries?

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@jkotas
Copy link
Member

jkotas commented Mar 13, 2020

The GCC leg should be build-only. No tests.

@AndyAyersMS
Copy link
Member

I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.

@jkotas
Copy link
Member

jkotas commented Mar 13, 2020

I've been trying to repro the x64 linux checked failure since it hit one of my PRs. No luck so far. No crash dump from the failure either.

This makes the GCC change more likely culprit.

@safern
Copy link
Member

safern commented Mar 13, 2020

There is a crashdump here:
https://helix.dot.net/api/2019-06-17/jobs/14a272be-d6cc-4e17-8d7d-b5d9779b14f9/workitems/Microsoft.Extensions.FileProviders.Physical.Tests/files/core.1000.2280

The GCC leg should be build-only. No tests.

I believe it is build-only, but let me look at it. That could probably be the issue, probably the GCC leg is overriding the real coreclr artifacts. Looking now.

@safern
Copy link
Member

safern commented Mar 13, 2020

Yeah. That is the issue from looking at the logs it is overriding the bin. /__w/1/a/CoreCLRProduct_Linux_x64_checked.tar.gz

I'll disable the publishing of the coreclr artifacts of GCC as it is not needed. I'll put up a PR to fix it in a sec. cc: @am11

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@AndyAyersMS
Copy link
Member

In my CI runs, we publish two sets of test native binaries -- looks like the GCC ones overwrite the CLANG ones...?

Clang build

2020-03-13T02:16:51.1504698Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:16:52.0113746Z Associated artifact 9333321 with build 558004

GCC build

2020-03-13T02:18:47.2572495Z Upload '/datadisks/disk1/workspace/_work/1/a/CoreCLRNativeTestArtifacts_Linux_x64_checked.tar.gz' to file container: '#/3640630/CoreCLRNativeTestArtifacts_Linux_x64_checked'
2020-03-13T02:18:48.0415092Z Associated artifact 9333321 with build 558004

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime (Libraries Test Run checked coreclr Linux x64 Debug), runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug), runtime
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Mar 13, 2020

Yeah. It seems like it doesn't repro all the time because it depends which leg finishes first.

I put up a PR to fix it: #33580

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 13, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: runtime, runtime (CoreCLR Pri0 Test Run Linux x64 checked), runtime (Libraries Test Run checked coreclr Linux x64 Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@safern
Copy link
Member

safern commented Mar 14, 2020

Failures are known and fixed: #33580

@safern safern merged commit b22719b into master Mar 14, 2020
@safern safern deleted the darc-master-c7356387-993d-40ed-a402-8ccffcbdeca9 branch March 14, 2020 03:46
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
@danmoseley danmoseley added area-codeflow for labeling automated codeflow and removed area-Infrastructure labels Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants