Add pipeline setup for jit offbydefault extra testing #33709
Conversation
Create a pipeline to test functionality in the jit that is not (yet) enabled by default: * object stack allocation * eh write through * on stack replacement (+ osr stress) * guarded devirtualization Currently just x64, pri1 tests.
|
@dotnet/jit-contrib PTAL Trial run here (has some failures we'll need to sort through). |
|
Cancelled run was against the staging branch -- I was wanted to see if the OSX dependence had been properly removed. Not clear why it shows up here. I suppose whatever collates testing status is matching on commit. |
| @@ -126,6 +133,11 @@ | |||
| <TestEnvironment Include="gcstress0xc_jitstress1" GCStress="0xC" JitStress="1" /> | |||
| <TestEnvironment Include="gcstress0xc_jitstress2" GCStress="0xC" JitStress="2" /> | |||
| <TestEnvironment Include="gcstress0xc_jitminopts_heapverify1" GCStress="0xC" JITMinOpts="1" HeapVerify="1" /> | |||
| <TestEnvironment Include="jitosr" TC_OnStackReplacment="1" TC_QuickJitForLoops="1" TieredCompilation="1"/> | |||
There was a problem hiding this comment.
Nit: for consistency can you please put a space between " and />.
| @@ -378,6 +378,13 @@ jobs: | |||
| scenarios: | |||
| - jitelthookenabled | |||
| - jitelthookenabled_tiered | |||
| ${{ if in(parameters.testGroup, 'jit-offbydefault-extra') }}: | |||
There was a problem hiding this comment.
Is there any alternatives for naming this pipeline other than offbydefault?
jitexperimentalfeatures? or just jitexperimental
My first thoughts when I read offbydefault were that this pipeline is off by default. But then I saw a schedule trigger and realized that this is about the jit features.
There was a problem hiding this comment.
Happy to rename if it reduces confusion -- @dotnet/jit-contrib any other thoughts/suggestions?
There was a problem hiding this comment.
I like "jit-experimental". I don't think you need "-extra" (We could save that for a version of this that also does JitStress modes, perhaps.)
|
|
||
| schedules: | ||
| - cron: "0 10 * * 6,0" | ||
| displayName: Sat and Sun at 2:00 AM (UTC-8:00) |
There was a problem hiding this comment.
Is there any other pipelines running at the same time that would compete with this one?
There was a problem hiding this comment.
This kicks off at the same time as the other weekend runs, I can certainly change it...
|
Test environment syntax was off in a few other places as well. |
Thank you for fixing this! |
| - cron: "0 10 * * 6,0" | ||
| displayName: Sat and Sun at 2:00 AM (UTC-8:00) | ||
| - cron: "0 22 * * 0" | ||
| displayName: Sun at 2:00 PM (UTC-8:00) |
There was a problem hiding this comment.
IMO, it's useful for it to run both Saturday and Sunday. Not because we need both runs, but because you're less likely for the weekly testing to be completely torpedoed by a single infrastructure failure.
| @@ -378,6 +378,13 @@ jobs: | |||
| scenarios: | |||
| - jitelthookenabled | |||
| - jitelthookenabled_tiered | |||
| ${{ if in(parameters.testGroup, 'jit-offbydefault-extra') }}: | |||
There was a problem hiding this comment.
I like "jit-experimental". I don't think you need "-extra" (We could save that for a version of this that also does JitStress modes, perhaps.)
|
All the jit-experimental runs seem to be testing what I intended. No real reason to wait for them to finish, but I'll do it anyways. |
|
Thanks @AndyAyersMS ! |
|
I noticed that the "runtime-jit-experimental" doesn't appear in the pipelines tree properly under dotnet/runtime: it appears at the top level. @jashook @echesakovMSFT do you know why? https://dev.azure.com/dnceng/public/_build?view=folders&treeState=XGRvdG5ldCRcZG90bmV0XHJ1bnRpbWU%3D |
|
@BruceForstall I think it was created this way - you can move it if you want by clicking "Rename/move" and pick a folder |
|
ok, I moved it. Hopefully that doesn't break anything! |
ghost
locked as resolved and limited conversation to collaborators
Create a pipeline to test functionality in the jit that is not (yet)
enabled by default:
Currently just x64, pri1 tests.