Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pipeline setup for jit offbydefault extra testing #33709

Merged
merged 7 commits into from
Mar 19, 2020
Merged

Add pipeline setup for jit offbydefault extra testing #33709

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f2cbaec
Add pipeline setup for jit offbydefault extra testing
AndyAyersMS Mar 17, 2020
2b54fb9
try not to require OSX build/test
AndyAyersMS Mar 18, 2020
fc4442b
update schedule; fix test environment syntax and typos
AndyAyersMS Mar 18, 2020
84a38a0
one more test env fix
AndyAyersMS Mar 18, 2020
d45c566
run on saturday too
AndyAyersMS Mar 18, 2020
add9c03
rename pipeline to jit-expermental
AndyAyersMS Mar 18, 2020
9266de5
more renaming
AndyAyersMS Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/pipelines/coreclr/jit-offbydefault-extra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ trigger: none
pr: none

schedules:
- cron: "0 10 * * 6,0"
displayName: Sat and Sun at 2:00 AM (UTC-8:00)
- cron: "0 22 * * 0"
displayName: Sun at 2:00 PM (UTC-8:00)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it's useful for it to run both Saturday and Sunday. Not because we need both runs, but because you're less likely for the weekly testing to be completely torpedoed by a single infrastructure failure.

branches:
include:
- master
Expand Down
12 changes: 6 additions & 6 deletions src/coreclr/tests/testenvironment.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
COMPlus_TC_OnStackReplacement;
COMPlus_TC_QuickJitForLoops;
COMPlus_TC_OnStackReplacement_InitialCounter;
COMplus_OSR_HitLimit;
COMPlus_OSR_HitLimit;
COMPlus_JitEnableGuardedDevirtualization;
COMPlus_EnableEHWriteThru;
COMPlus_JitObjectStackAllocation
Expand Down Expand Up @@ -133,11 +133,11 @@
<TestEnvironment Include="gcstress0xc_jitstress1" GCStress="0xC" JitStress="1" />
<TestEnvironment Include="gcstress0xc_jitstress2" GCStress="0xC" JitStress="2" />
<TestEnvironment Include="gcstress0xc_jitminopts_heapverify1" GCStress="0xC" JITMinOpts="1" HeapVerify="1" />
<TestEnvironment Include="jitosr" TC_OnStackReplacment="1" TC_QuickJitForLoops="1" TieredCompilation="1"/>
<TestEnvironment Include="jitosr_stress" TC_OnStackReplacment="1" TC_QuickJitForLoops="1" TC_OnStackReplacement_InitialCounter="1" OSR_HitLimit="1" TieredCompilation="1"/>
<TestEnvironment Include="jitguardeddevirtualization" JitEnableGuardedDevirtualization="1" TieredCompilation="0"/>
<TestEnvironment Include="jitehwritethru" EnableEhWriteThru="1" TieredCompilation="0"/>
<TestEnvironment Include="jitobjectstackallocation" JitObjectStackAllocation="1" TieredCompilation="0"/>
<TestEnvironment Include="jitosr" TC_OnStackReplacement="1" TC_QuickJitForLoops="1" TieredCompilation="1" />
<TestEnvironment Include="jitosr_stress" TC_OnStackReplacement="1" TC_QuickJitForLoops="1" TC_OnStackReplacement_InitialCounter="1" OSR_HitLimit="1" TieredCompilation="1" />
<TestEnvironment Include="jitguardeddevirtualization" JitEnableGuardedDevirtualization="1" TieredCompilation="0" />
<TestEnvironment Include="jitehwritethru" EnableEhWriteThru="1" TieredCompilation="0" />
<TestEnvironment Include="jitobjectstackallocation" JitObjectStackAllocation="1" TieredCompilation="0" />
</ItemGroup>

<!-- We use target batching on the COMPlusVariable items to iterate over the all COMPlus_* environment variables
Expand Down