Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync HttpClient Send #34948

Merged
merged 80 commits into from
Jun 24, 2020
Merged

Sync HttpClient Send #34948

merged 80 commits into from
Jun 24, 2020

Commits on Jan 29, 2020

  1. Moved and fixed code from https://github.com/stephentoub/corefx/tree/… 

    …socketshttphandlersync

stephentoub/corefx@0e4d640

Little compilation fix.


Compilaris


Test compilaris

Fixed buffer sending not passing offset and count.
    @ManickaP
    ManickaP committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    1e11d42 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Sync on HttpMessageInvoker instead of SocketHandler

    @ManickaP
    ManickaP committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    8a96eab View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Merge branch 'master' 

    Conflicts:
	src/libraries/Common/tests/System/Net/Http/LoopbackServer.cs
	src/libraries/System.Net.Http/src/System.Net.Http.csproj
	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
    @ManickaP
    ManickaP committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    0db4f95 View commit details
    Browse the repository at this point in the history

  2. Fix after merge

    @ManickaP
    ManickaP committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    8b9baeb View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Merge remote-tracking branch 'upstream/master' into mapichov/sync_htt… 

    …p_api
    @ManickaP
    ManickaP committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    b4cdb9d View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Sync HttpClient.Send, including timeout and cancellation

    @ManickaP
    ManickaP committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    3eeff26 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Merge branch 'master' into mapichov/sync_http_api 

    # Conflicts:
#	src/libraries/System.Net.Http/ref/System.Net.Http.cs
#	src/libraries/System.Net.Http/src/System.Net.Http.csproj
#	src/libraries/System.Net.Http/src/System/Net/Http/DiagnosticsHandler.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/HttpContent.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/MultipartContent.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/ReadOnlyMemoryContent.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnection.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionBase.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPoolManager.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpContentWriteStream.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/SocketsHttpHandler.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/StreamContent.cs
    @ManickaP
    ManickaP committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    4b9b048 View commit details
    Browse the repository at this point in the history

  2. Fixed compilation after merge.

    @ManickaP
    ManickaP committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    13b7d33 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Merge branch 'master' of github.com:dotnet/runtime into mapichov/sync… 

    …_http_api
    @ManickaP
    ManickaP committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    4fcb464 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. HttpClient Send tests.

    @ManickaP
    ManickaP committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    836c6a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Merge remote-tracking branch 'upstream/master' into mapichov/sync_htt… 

    …p_api
    @ManickaP
    ManickaP committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    de52d34 View commit details
    Browse the repository at this point in the history

  2. Post merge fixes.

    @ManickaP
    ManickaP committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    c9b5907 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. AutoRedirect and Authenticaton sync tests done.

    @ManickaP
    ManickaP committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    8e6abc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Cancellation sync tests

    @ManickaP
    ManickaP committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    f930e5f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mapichov/sync_http_api

    @ManickaP
    ManickaP committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    bacb741 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. Sync Cookie tests.

    @ManickaP
    ManickaP committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    25ecee6 View commit details
    Browse the repository at this point in the history

  2. Sync HttpClientHandlerTest

    @ManickaP
    ManickaP committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    dd6ca30 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Merge branch 'master' into mapichov/sync_http_api 

    # Conflicts:
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionBase.cs
#	src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
    @ManickaP
    ManickaP committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    8ee2baf View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Merge branch 'master' into mapichov/sync_http_api

    @ManickaP
    ManickaP committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    941f921 View commit details
    Browse the repository at this point in the history

  2. net472 compilaris

    @ManickaP
    ManickaP committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    ecee08f View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Removed offloading of client/server tasks to another thread in Loopba… 

    …ckServer.
    @ManickaP
    ManickaP committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    34809a5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mapichov/sync_http_api

    @ManickaP
    ManickaP committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    8824ac9 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Removed unused method.

    @ManickaP
    ManickaP committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    a2a653e View commit details
    Browse the repository at this point in the history

  2. Cory's comments. 

    Nits, asserts, default parameters
    @ManickaP
    ManickaP committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    724241a View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Stephen's nits, renames, comments.

    @ManickaP
    ManickaP committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    07699aa View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. 100-continue todo resolved.

    @ManickaP
    ManickaP committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    d25d2d6 View commit details
    Browse the repository at this point in the history

  2. ByteAtATimeContent sync over async for tests.

    @ManickaP
    ManickaP committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    c00d8ea View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. HttpClient and HttpContent refactored duplicate code.

    @ManickaP
    ManickaP committed May 5, 2020
    Configuration menu
    Copy the full SHA
    9a78f71 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Merge branch 'master' into mapichov/sync_http_api

    @ManickaP
    ManickaP committed May 6, 2020
    Configuration menu
    Copy the full SHA
    bc9bdb9 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Merge branch 'master' into mapichov/sync_http_api 

    # Conflicts:
#	src/libraries/System.Net.Http/src/System/Net/Http/HttpContent.cs
    @ManickaP
    ManickaP committed May 13, 2020
    Configuration menu
    Copy the full SHA
    0e7a74d View commit details
    Browse the repository at this point in the history

  2. Throwing NSE instead of sync-over-async.

    @ManickaP
    ManickaP committed May 13, 2020
    Configuration menu
    Copy the full SHA
    c1de37c View commit details
    Browse the repository at this point in the history

  3. Fixed compiler constant.

    @ManickaP
    ManickaP committed May 13, 2020
    Configuration menu
    Copy the full SHA
    6de79c2 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Reworked tests to use inheritance instead of a test parameter. 

    MemberData must be static. Current HttpVersion (virtual property) cannot be used in data generation (i.e. AsyncBoolValue).
    @ManickaP
    ManickaP committed May 14, 2020
    Configuration menu
    Copy the full SHA
    0a32c84 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Fixed throwing NSE and missing sync implementations.

    @ManickaP
    ManickaP committed May 18, 2020
    Configuration menu
    Copy the full SHA
    b968275 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Fixed Cancellation tests

    @ManickaP
    ManickaP committed May 20, 2020
    Configuration menu
    Copy the full SHA
    f173650 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. More tests fixed.

    @ManickaP
    ManickaP committed May 21, 2020
    Configuration menu
    Copy the full SHA
    e0b8c0d View commit details
    Browse the repository at this point in the history

  2. Moar tests.

    @ManickaP
    ManickaP committed May 21, 2020
    Configuration menu
    Copy the full SHA
    77b406f View commit details
    Browse the repository at this point in the history

  3. Even moar tests.

    @ManickaP
    ManickaP committed May 21, 2020
    Configuration menu
    Copy the full SHA
    9a32c9d View commit details
    Browse the repository at this point in the history

  4. Removed unnecessary changes.

    @ManickaP
    ManickaP committed May 21, 2020
    Configuration menu
    Copy the full SHA
    3da68cb View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Fixed tests.

    @ManickaP
    ManickaP committed May 26, 2020
    Configuration menu
    Copy the full SHA
    5fc5ac0 View commit details
    Browse the repository at this point in the history

  2. HttpStream sync write clean up.

    @ManickaP
    ManickaP committed May 26, 2020
    Configuration menu
    Copy the full SHA
    8b8463c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mapichov/sync_http_api

    @ManickaP
    ManickaP committed May 26, 2020
    Configuration menu
    Copy the full SHA
    11021c6 View commit details
    Browse the repository at this point in the history

  4. Sync AuthenticateAsClient usage

    @ManickaP
    ManickaP committed May 26, 2020
    Configuration menu
    Copy the full SHA
    a0f0a5d View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Handle cancellation and subsequent exception mapping.

    @ManickaP
    ManickaP committed May 29, 2020
    Configuration menu
    Copy the full SHA
    0dcf44e View commit details
    Browse the repository at this point in the history

  2. Fixed deadlocking tests

    @ManickaP
    ManickaP committed May 29, 2020
    Configuration menu
    Copy the full SHA
    6f28a2b View commit details
    Browse the repository at this point in the history

Commits on May 30, 2020

  1. Merge remote-tracking branch 'upstream/master' into mapichov/sync_htt… 

    …p_api
    @ManickaP
    ManickaP committed May 30, 2020
    Configuration menu
    Copy the full SHA
    c8d2336 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Merge remote-tracking branch 'upstream/master' into mapichov/sync_htt… 

    …p_api
    @ManickaP
    ManickaP committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    f8a8219 View commit details
    Browse the repository at this point in the history

  2. Fixed merge

    @ManickaP
    ManickaP committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    c8b46a6 View commit details
    Browse the repository at this point in the history

  3. Fixed compilaris for browser.

    @ManickaP
    ManickaP committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    4e412e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Single thread execution tests.

    @ManickaP
    ManickaP committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    86171b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Cancellation tests

    @ManickaP
    ManickaP committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    a53aee7 View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary changes.

    @ManickaP
    ManickaP committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    9501109 View commit details
    Browse the repository at this point in the history

  3. Missing TestAsync.

    @ManickaP
    ManickaP committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    41212be View commit details
    Browse the repository at this point in the history

  4. Tests.

    @ManickaP
    ManickaP committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    b6f86f9 View commit details
    Browse the repository at this point in the history

  5. Timeout tests.

    @ManickaP
    ManickaP committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    52c5601 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Clean up after dotnet#37441 discussion

    @ManickaP
    ManickaP committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    0f90f0c View commit details
    Browse the repository at this point in the history

  2. Response content timeout test.

    @ManickaP
    ManickaP committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    453aa6b View commit details
    Browse the repository at this point in the history

  3. Timeout tests too slow to check for exact call stack line.

    @ManickaP
    ManickaP committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    157431c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into mapichov/sync_http_api

    @ManickaP
    ManickaP committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    bbcc5a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Review comments.

    @ManickaP
    ManickaP committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    d9de995 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mapichov/sync_http_api

    @ManickaP
    ManickaP committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    eeb5fa1 View commit details
    Browse the repository at this point in the history

  3. Review comments.

    @ManickaP
    ManickaP committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    f20d300 View commit details
    Browse the repository at this point in the history

  4. Resx review comments.

    @ManickaP
    ManickaP committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    0f8bbd8 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Last review comments.

    @ManickaP
    ManickaP committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    43ed804 View commit details
    Browse the repository at this point in the history

  2. Fail proofing tests.

    @ManickaP
    ManickaP committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    04d567f View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Merge branch 'master' into current

    @ManickaP
    ManickaP committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    0f58108 View commit details
    Browse the repository at this point in the history

  2. Removed some unnecessary newlines.

    @ManickaP
    ManickaP committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    53c24a9 View commit details
    Browse the repository at this point in the history

  3. Explanation why the test is skipped.

    @ManickaP
    ManickaP committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    1bc2f15 View commit details
    Browse the repository at this point in the history

  4. ConnectHelper.ConnectAsync split even further.

    @ManickaP
    ManickaP committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    864b158 View commit details
    Browse the repository at this point in the history

  5. Renamed resource.

    @ManickaP
    ManickaP committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    77669b8 View commit details
    Browse the repository at this point in the history

  6. Removed check for missing SerializeToStream override from HttpContent.

    @ManickaP
    ManickaP committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    c624dd8 View commit details
    Browse the repository at this point in the history

  7. DiagnosticHandler and task status.

    @ManickaP
    ManickaP committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    ed6eb2a View commit details
    Browse the repository at this point in the history

  8. The last of the comments

    @ManickaP
    ManickaP committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    851c8b6 View commit details
    Browse the repository at this point in the history

  9. Fixed test hanging on 3s timeout.

    @ManickaP
    ManickaP committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    2eb6c2d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Merge branch 'master' into mapichov/sync_http_api

    @ManickaP
    ManickaP committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    92f4540 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Merge branch 'master' into mapichov/sync_http_api

    @ManickaP
    ManickaP committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    12d1bca View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Fixed method visibility

    @ManickaP
    ManickaP committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    7e5c47d View commit details
    Browse the repository at this point in the history

  2. Fixed hanging tests.

    @ManickaP
    ManickaP committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    96eccce View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mapichov/sync_http_api

    @ManickaP
    ManickaP committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    0355117 View commit details
    Browse the repository at this point in the history

  4. Proofing test against slow infra.

    @ManickaP
    ManickaP committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    7844fbf View commit details
    Browse the repository at this point in the history