Fix all runtime IL generation paths from passing GC types to unmanaged function calls. #35026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Apr 15, 2020
AaronRobinsonMSFT
force-pushed
the
runtime_34279
branch
2 times, most recently
from
1e43992
to
8d6f00f
Compare
|
@davidwrighton and @MichalStrehovsky for crossgen2 changes. |
jkotas
reviewed
Apr 17, 2020
jkotas
approved these changes
Apr 17, 2020
|
Hello @AaronRobinsonMSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
davidwrighton
approved these changes
Apr 17, 2020
|
Le sigh... Dynamic runtime |
AaronRobinsonMSFT
force-pushed
the
runtime_34279
branch
from
8d6f00f
to
8ab8d24
Compare
AaronRobinsonMSFT
changed the title
AaronRobinsonMSFT
force-pushed
the
runtime_34279
branch
from
8ab8d24
to
512a39b
Compare
|
... and IJW ... Also it looks like during the switch over to SDK test projects we inadvertently disabled all native COM client tests for consuming managed COM servers. I am re-enabling them in this PR but will rebase when I merge so the two commits exist. |
|
... and WinRT ... |
Update crossgen2 IL stub generators. Update Dynamic runtime stub generator. Add assert for GC types in unmanaged function calls.
AaronRobinsonMSFT
force-pushed
the
runtime_34279
branch
from
512a39b
to
2433309
Compare
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34279
Update: The assert added in this PR impacts more than first thought. When a P/Invoke, call in IL, is inlined any native arguments must be converted (
conv.i/conv.u) prior to the call since the IL marshaler fixes in this PR won't run. See #35187 for an example./cc @jkoritzinsky @elinor-fung @jkotas @AndyAyersMS