Stop passing GC types to P/Invokes in IL tests. #35207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
added
the
area-CodeGen-coreclr
AaronRobinsonMSFT
added
test-enhancement
|
Hello @AaronRobinsonMSFT! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
AaronRobinsonMSFT
changed the title
jkotas
reviewed
Apr 20, 2020
src/coreclr/tests/src/JIT/Directed/IL/PInvokeTail/PInvokeTail.il
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
force-pushed
the
runtime_35187
branch
from
9d98d8b
to
832adec
Compare
jkotas
reviewed
Apr 21, 2020
AaronRobinsonMSFT
force-pushed
the
runtime_35187
branch
from
832adec
to
9925cfc
Compare
jkotas
reviewed
Apr 21, 2020
AaronRobinsonMSFT
force-pushed
the
runtime_35187
branch
from
9925cfc
to
5d11ef4
Compare
jkotas
approved these changes
Apr 21, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35187
This issue was caused by the assert added in #35026.
/cc @dotnet/jit-contrib @jkotas