Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run wasm tests on Helix #37752

Merged
merged 120 commits into from
Jun 25, 2020
Merged

Run wasm tests on Helix #37752

merged 120 commits into from
Jun 25, 2020

Conversation

directhex
Copy link
Contributor

Let's see what happens. Based on latest iOS PR.

premun and others added 30 commits June 5, 2020 11:39
None of these fixes are wrong per se (maybe the ApkBuilder changes?) but they complicate the PR by mixing unrelated changes
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
@steveisok steveisok self-requested a review June 19, 2020 22:06
@safern
Copy link
Member

safern commented Jun 19, 2020

Taking a final look.

directhex and others added 2 commits June 22, 2020 10:01
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
@directhex directhex merged commit a926345 into dotnet:master Jun 25, 2020
@safern
Copy link
Member

safern commented Jun 25, 2020

Wuhu 🎉

@directhex directhex deleted the wasm-helix-sdk branch June 25, 2020 19:51
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants