-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run wasm tests on Helix #37752
Merged
Merged
Run wasm tests on Helix #37752
Changes from all commits
Commits
Show all changes
120 commits
Select commit
Hold shift + click to select a range
be7b233
Add XHarness Helix SDK support
premun 066bafa
Try to build mono libraries
premun ebbf08b
Try to build mono libraries
premun 83d7cab
Address some of Santiago's feedback from Jo's PR
premun 1379eef
Merge runtime.yml from master
premun 98377f1
Build iOSx64 libraries
premun 495c602
Try to build mono product
premun c571262
Try to build mono product
premun 636bc66
Merge master
premun 9d9da07
Do not build AllSubsets
premun 21d5ebc
Remove dead code
premun df64e06
Revert: Do not built AllSubsets
premun 553147d
Disable test archivation
premun 9e7d3f2
Improvements for local test running
directhex 138706f
Merge branch 'prvysoky/use-helix-sdk' of github.com:premun/runtime in…
directhex 2a2243d
Return dead code
premun 030511c
Reintroduce whitespace errors
directhex d1a4226
Bump Helix SDK and keep trailing slashes
premun d3366ae
Revert "Bump Helix SDK and keep trailing slashes"
premun 16168da
Try building 2 app bundles
premun 64da851
Try a cleaner `.app` find in msbuild, from @akoeplinger
directhex 506afd2
Revert "Try a cleaner `.app` find in msbuild, from @akoeplinger"
directhex 6778369
Do not archiveTests on iOS, it causes tests to be included twice
directhex f3252fd
Revert "Revert "Try a cleaner `.app` find in msbuild, from @akoepling…
directhex 2743b13
Turn on all the tests on iOS
directhex 8a2c248
Merge remote-tracking branch 'origin/master' into prvysoky/use-helix-sdk
directhex 6f6731e
Remove Android changes, to keep scope of PR smaller
directhex e6a94dd
Update global.json
directhex 8f07f4c
Update src/libraries/sendtohelix.proj
directhex 3d73fc6
Remove useless archiveTests=false
directhex 0e0403f
Update src/libraries/sendtohelix.proj
directhex 01cc2b1
Merge remote-tracking branch 'origin/master' into prvysoky/use-helix-sdk
premun aee9b85
Fix runtime-packs dir
premun 3f2f23c
Revert changes in yml to use new mono build workflow
safern bcc7dcc
Merge remote-tracking branch 'dotnet/master' into prvysoky/use-helix-sdk
safern ffb1b02
Add iOS x64 testing to new collapsed build model
safern 1e9eb5d
Just run System.Buffers.Tests to make testing faster
safern 0b6b5a5
Set helixQueuesTemplate in the right place
safern 7c23cd7
Set XHarness version in Version.props
premun 1671125
Roll back to XHarness that supports Xcode 11.4
premun 1f9c3cf
Cleanup
safern 413e135
Merge remote-tracking branch 'origin/master' into prvysoky/use-helix-sdk
premun 82ff98a
Add XHarness CLI to Version.Details.xml
premun 5f97549
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex a5e7bb3
Only test System.Buffers for now
directhex 6b62ca3
Try enabling testing for Wasm
directhex 9cfa895
Move Wasm run to template which calls Helix
directhex 6fb4ff2
Set a helix queue for wasm
directhex 03b5001
Ensure we archive tests on WebAssembly
directhex cd18d9a
Be careful about using TargetsMobile, which is true on Wasm(?)
directhex 1b74d80
Override artifact directory on wasm
directhex 12603f1
Let's install dotnet and xharness for wasm
directhex 9f9f758
fixup
directhex 335b0ce
HELIX_CORRELATION_PAYLOAD is readonly in docker
directhex 9e47f39
Handle xharness directory
directhex 248316a
Fiddle Helix launcher to run test suite
directhex bee0215
Cleanup RunTests script generation for wasm
safern a80a5d1
Give runtime.js executable permisions
safern 6ead7f8
Fix ArchiveTest target to run after app bundle is created
safern a7b7b8f
Pre-install XHarness CLI using the Helix SDK
premun a3a8ded
Pre-install XHarness CLI using the Helix SDK
premun 8fda27d
Revert "Pre-install XHarness CLI using the Helix SDK"
premun b3d4c70
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 17767b3
Turn on all tests on wasm
directhex 8ad3678
Skip test suite which hangs
directhex d279758
Disable test suites which don't emit result XML
directhex 36a876f
Skip all tests which don't pass yet
directhex 18ead20
Increase timeout on global-build-job
directhex bd09ec0
Normalise on Windows path seperators
directhex 44499ad
Merge branch 'wasm-helix-sdk' of github.com:directhex/runtime into wa…
directhex 12284ec
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 9f124aa
Remove another test suite which doesn't pass any more
directhex a7a668c
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 27f8227
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 582d247
Try using HelixPreCommand Include, not a big HelixPreCommands string
directhex 0706453
ItemGroup not PropertyGroup
directhex ec073af
Typo
directhex dec8dac
More typos
directhex ce3fd5d
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 03acee5
Remove iOS changes, and prepare for un-drafting
directhex 1c74889
More fixups
directhex ce51fd4
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 5bbf116
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 90f9046
Move directory zip definition to the right place
directhex 112d702
Put dependency back how it was (gotta figure out why it's bad though)
directhex 4e52d5c
Fix circular dependency issue
akoeplinger ffe2fc3
Sequence ArchiveTests correctly for browser
safern 2e2d618
Deal with nits from Alex
directhex 680582a
Refresh list of failing tests
directhex 7a165e4
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 8ce3964
Define msbuildScript in global-build jobs (i.e. wasm)
directhex ef84e2f
Add cleanup in helix.yml missed on merge with master
safern 270c30d
Don't compress teshost for Browser
safern b021230
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 0dd57f0
non-building tests now build
directhex 42958de
Use Helix SDK to install xharness
directhex 75d2cb5
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex afaffb8
Revert "Use Helix SDK to install xharness"
directhex 2c8e3bb
Enable System.Console
directhex ab99533
Skip another suite, which maybe only started being included via depen…
directhex a1216c5
Move timeoutInMinutes to the right place
directhex 94d4c08
Merge branch 'master' into wasm-helix-sdk
akoeplinger a2e630b
Reenable test projects that pass now
akoeplinger 5b7e592
Update src/libraries/sendtohelixhelp.proj
directhex 25d1eac
Fixup for Premek's change
directhex 2221b51
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 9eb9753
ActiveIssue on Crypto test in Format.Cbor
directhex ee4c2f8
Another ActiveIssue on Cbor Crypto test
akoeplinger 6745a0f
Merge remote-tracking branch 'upstream/master' into wasm-helix-sdk
akoeplinger 069a428
Merge remote-tracking branch 'origin/master' into wasm-helix-sdk
directhex 7737d7b
Merge remote-tracking branch 'upstream/master' into wasm-helix-sdk
akoeplinger 80c1930
Enable three more testsuites that pass now
akoeplinger 42644a6
Reenable System.Reflection.Emit.ILGeneration
akoeplinger bf2f9a1
Revert "Revert "Use Helix SDK to install xharness""
directhex 3cdf5e7
Run wasm tests in bare Ubuntu 20.04 queue, not in Docker
directhex dd894da
Merge remote-tracking branch 'upstream/master' into wasm-helix-sdk
akoeplinger 64323dd
Reenable two more test suites
akoeplinger d062ba2
Merge remote-tracking branch 'upstream/master' into wasm-helix-sdk
akoeplinger 2686b84
Reenable three more test suites
akoeplinger 4172524
Merge branch 'wasm-helix-sdk' of github.com:directhex/runtime into wa…
directhex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add support to condition the extra steps... I can imagine the tests being executed when there is an installer only change. I think it would only make sense to run wasm tests if libraries or mono tests change, but build if libraries, mono or installer changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I understood you correctly here, but we do need to run the wasm tests if the libraries or mono implementation changes, not just the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean is run the tests if mono or libraries change only, don’t run the tests if only installer is changed. We can do that in a follow up PR though