Fix il verification tests #39538
Fix il verification tests #39538
Conversation
This reverts commit ecb231c.
- Re-enable the test project build - Change string resources in type system to directly use ResourceManager instead of SR abstraction which is unavaliable in the test build tree - Add test to verify that all ExceptionStringID values have associated strings - Use ToolsCommonPath property to successfully reference the correct resource file
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
@dotnet/crossgen-contrib |
davidwrighton
added
area-crossgen2-coreclr
area-Tools-ILVerification
|
As a side benefit I tweaked the source so that it uses |
| @@ -13,6 +16,9 @@ public abstract class TypeSystemException : Exception | |||
| { | |||
| private string[] _arguments; | |||
|
|
|||
| private static Lazy<ResourceManager> s_stringResourceManager = | |||
There was a problem hiding this comment.
Would it be possible to pull this out of TypeSystemException.cs into a separate file? This will not work when the type system is used as a runtime type system (we need to be able to get rid of ResourceManager in the UseSystemResourceKeys mode and that one relies on the SR type).
I think now I'm remembering why these were [TEMPORARY EXCEPTION MESSAGE] for such a long time...
Also the id.ToString() will not work because the enum is reflection blocked in the runtime type system.
There was a problem hiding this comment.
Yes, I'll pull these out into a separate file. Good point on the CoreRT impact. I had forgotten some of these details. Someone in the CoreRT repo will need to implement the resource lookup function in whatever way actually makes sense at runtime.
* Revert "delete test project. (dotnet#39501)" This reverts commit ecb231c. * Fix ILVerification tests - Re-enable the test project build - Change string resources in type system to directly use ResourceManager instead of SR abstraction which is unavaliable in the test build tree - Add test to verify that all ExceptionStringID values have associated strings - Use ToolsCommonPath property to successfully reference the correct resource file * Address feedback and allow the strings to be handled with a runtime implementation
ghost
locked as resolved and limited conversation to collaborators
Fixes #39504