Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation update to test setup #39712

Closed
wants to merge 1 commit into from

Conversation

mfkl
Copy link
Contributor

@mfkl mfkl commented Jul 21, 2020

Specify additional necessary flag in the docs command.

Fix #36528 (which I ran into on Windows as well).

Specify additional necessary flag in the docs command. Fix dotnet#36528
```

For Windows:
```bat
./build.cmd -runtimeConfiguration Release
./build.cmd -runtimeConfiguration Release -c Release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but these changes aren't correct. Adding the -c Release will make everything build as release, whereas the text above cites these examples are for debug libraries and debug installer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That did fix my issue when building at the time, but alright. Closing.

@mfkl mfkl closed this Oct 24, 2020
@mfkl mfkl deleted the docfix/run-tests branch October 24, 2020 05:12
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"The 'libs' subset must be built before building this project" when subset has been built
3 participants