Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation update to test setup #39712

Closed
wants to merge 1 commit into from
Closed

Minor documentation update to test setup #39712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/workflow/building/libraries/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@ These example commands will build a release CoreCLR (and CoreLib), debug librari

For Linux:
```bash
./build.sh -runtimeConfiguration Release
./build.sh -runtimeConfiguration Release -c Release
```

For Windows:
```bat
./build.cmd -runtimeConfiguration Release
./build.cmd -runtimeConfiguration Release -c Release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but these changes aren't correct. Adding the -c Release will make everything build as release, whereas the text above cites these examples are for debug libraries and debug installer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That did fix my issue when building at the time, but alright. Closing.

```

Detailed information about building and testing runtimes and the libraries is in the documents linked below.
Expand Down
2 changes: 1 addition & 1 deletion docs/workflow/testing/coreclr/testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Details on test metadata can be found in [test-configuration.md](test-configurat
* [Unix](../../building/coreclr/linux-instructions.md)
* [macOS](../../building/coreclr/osx-instructions.md)
* [Windows](../../building/coreclr/README.md)
2) [Build the libraries](../../building/libraries/README.md) in Release configuration. Pass the configuration of CoreCLR you just built to the build script (e.g. `-runtimeconfiguration debug`).
2) [Build the libraries](../../building/libraries/README.md) in Release configuration. Pass the configuration of CoreCLR you just built to the build script (e.g. `-runtimeconfiguration Debug -c Release`).
3) From the `src/coreclr` directory run the following command:
* Non-Windows - `./build-test.sh`
* Windows - `build-test.cmd`
Expand Down