[Wasm] Enable CopyWithData FileSystem test #40663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdh1418
approved these changes
Aug 11, 2020
safern
reviewed
Aug 11, 2020
| // | ||
| // For browser, work around limitation of File.Copy, which | ||
| // fails when trying to open the dest file | ||
| if (PlatformDetection.IsBrowser && readOnly) |
There was a problem hiding this comment.
Move this if to the if (readOnly) above?
There was a problem hiding this comment.
Nevermind, we can't because of the else 😄
safern
approved these changes
Aug 11, 2020
|
Fixes #40543 |
mdh1418
pushed a commit
to mdh1418/runtime
that referenced
this pull request
Aug 18, 2020
This reverts commit 1821567.
mdh1418
added a commit
that referenced
this pull request
Aug 20, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.