[wasm] Skip Assert.InRange in Copy.cs for Browser #41000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #40663.
By reverting dotnet/corefx#37583 in #40753, the file time being set
runtime/src/libraries/Native/Unix/System.Native/pal_io.c
Line 1157 in 154e971
runtime/src/libraries/Native/Unix/System.Native/pal_io.c
Line 1173 in 154e971
Moreover, from some testing, it looks like
File.SetAttributes
will overwrite a file's LastWrite and LastAccess time on browser also probably due to Emscripten's implementation.The workaround in #40663 sets the file's LastWrite after
Copy
for readOnly files, but if we have to do that for both readOnly and non-readOnly because L1157 is defeated by L1173, then theAssert.InRange
check is trivial and we should instead skip this assert on Browser.