Mono: switch to CMake build on Windows #44976
Conversation
akoeplinger
force-pushed
the
cmake-windows
branch
from
9a5b9bb
to
9af146e
Compare
|
For consistency with the rest of the repo build, can we condition the switch to CMake+Ninja on the |
|
@jkoritzinsky yep, that's what I'm already doing :) |
akoeplinger
force-pushed
the
cmake-windows
branch
5 times, most recently
from
c2d3769
to
2858ab2
Compare
akoeplinger
requested review from
BrzVlad,
CoffeeFlux,
lambdageek,
marek-safar,
SamMonoRT,
thaystg and
vargaz
as code owners
|
The cmake changes looks ok to me otherwise. |
akoeplinger
force-pushed
the
cmake-windows
branch
4 times, most recently
from
04d3c18
to
3924792
Compare
This unifies the build with the other platforms.
akoeplinger
force-pushed
the
cmake-windows
branch
from
3924792
to
3c18170
Compare
| @@ -0,0 +1,89 @@ | |||
| @if not defined _echo @echo off | |||
There was a problem hiding this comment.
this file was extracted from https://github.com/dotnet/runtime/blob/master/src/libraries/Native/build-native.cmd and/or https://github.com/dotnet/runtime/blob/master/src/installer/corehost/build.cmd, we can unify these later on.
|
Can we get rid of (and stop mirroring) the old solution as part of this PR? |
|
@CoffeeFlux yes, I'll do that in a follow-up PR (it needs a small tweak in the mirror and that is cumbersome to do in sync with this PR). |
|
Merging since this PR unblocks other work dependent on it, but feel free to still review and I'll address it in follow-ups. |
They're no longer needed after dotnet#44976
They're no longer needed after #44976
ghost
locked as resolved and limited conversation to collaborators
This unifies the build with the other platforms.
Hooks up the versioning targets so the mono libraries get the correct version.