Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use substitute SHA-1 implementation in wasm #44982

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Use substitute SHA-1 implementation in wasm #44982

merged 2 commits into from
Nov 20, 2020

Conversation

GrabYourPitchforks
Copy link
Member

Contributes to #44884.

I don't have the ability to run tests locally, so crossing my fingers that CI's behaving tonight. :)

@GrabYourPitchforks GrabYourPitchforks added this to the 6.0.0 milestone Nov 20, 2020
@ghost
Copy link

ghost commented Nov 20, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #44884.

I don't have the ability to run tests locally, so crossing my fingers that CI's behaving tonight. :)

Author: GrabYourPitchforks
Assignees: -
Labels:

area-System.Security
Milestone: 6.0.0

@stephentoub
Copy link
Member

Did you consider separating EventSource's copy into its own file and just including it here as well?

@GrabYourPitchforks
Copy link
Member Author

Yes, but given the potential for servicing I wanted to touch as few files as possible. Ideally the wasm-specific code is being deleted in the next release anyway once we take a dependency on SubtleCrypto. If preference is instead to avoid code duplication I can definitely spin up another commit.

@stephentoub
Copy link
Member

Ideally the wasm-specific code is being deleted in the next release anyway once we take a dependency on SubtleCrypto

Ok.

@runfoapp runfoapp bot mentioned this pull request Nov 20, 2020
Closed
@stephentoub stephentoub merged commit a61b054 into dotnet:master Nov 20, 2020
@dagood dagood mentioned this pull request Nov 20, 2020
Merged
@omajid omajid mentioned this pull request Nov 24, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@bartonjs bartonjs Awaiting requested review from bartonjs

@lewing lewing Awaiting requested review from lewing

Assignees
No one assigned
Labels
area-System.Security
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GrabYourPitchforks @stephentoub @steveisok @akoeplinger