Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: Use substitute SHA-1 impl in wasm #1904

Merged
merged 1 commit into from
Nov 20, 2020
Merged

runtime: Use substitute SHA-1 impl in wasm #1904

merged 1 commit into from
Nov 20, 2020

Conversation

dagood
Copy link
Member

@dagood dagood commented Nov 20, 2020

Port dotnet/runtime#44982 from dotnet/runtime master to 5.0.0 GA as a source-build patch. (Applies cleanly.)

For dotnet/runtime#44884.

@dagood dagood self-assigned this Nov 20, 2020
omajid
omajid approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@omajid omajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read the code, but given that the change was verified in runtime and patch applies cleanly: 👍

@dagood dagood merged commit 29b9325 into dotnet:master Nov 20, 2020
@dagood dagood deleted the alt-sha1 branch November 20, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omajid omajid omajid approved these changes

@crummel crummel crummel approved these changes

@dseefeld dseefeld Awaiting requested review from dseefeld

Assignees

@dagood dagood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dagood @omajid @crummel