-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Task-based DisconnectAsync and refactor APM methods on top of it #51213
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAdd Task-based DisconnectAsync and refactor old APM Begin/EndDisconnect methods on top of it. Also, generalize and improve disconnect tests. Note that cancellation is not currently wired up for DisconnectAsync, even though it takes a CancellationToken. I'll file a separate issue for this. Fixes #1608
|
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated
Show resolved
Hide resolved
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
@antonfirsov -- I added a new helper |
Add Task-based DisconnectAsync and refactor old APM Begin/EndDisconnect methods on top of it.
Also, generalize and improve disconnect tests.
Note that cancellation is not currently wired up for DisconnectAsync, even though it takes a CancellationToken. I'll file a separate issue for this.
Fixes #1608
Contributes to #43845