Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symlinks left on disk by Installer runs breaks job log upload on Linux #51502

Closed
runfoapp bot opened this issue Apr 19, 2021 · 6 comments · Fixed by #51712
Closed

Symlinks left on disk by Installer runs breaks job log upload on Linux #51502

runfoapp bot opened this issue Apr 19, 2021 · 6 comments · Fixed by #51712
Labels
area-Host untriaged New issue has not been triaged by the area owner

Comments

@runfoapp
Copy link

runfoapp bot commented Apr 19, 2021 •
edited
Loading

Runfo Tracking Issue: Symlinks left on disk by Installer runs breaks job log upload on Linux

Definition Build Kind Job Name
runtime 1095811 PR 51495 Installer Build and Test coreclr Linux_x64 Release
runtime 1095811 PR 51495 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095762 PR 51493 Installer Build and Test coreclr Linux_x64 Release
runtime 1095762 PR 51493 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095757 PR 50930 Installer Build and Test coreclr Linux_x64 Release
runtime 1095757 PR 50930 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095692 PR 51457 Installer Build and Test coreclr Linux_x64 Release
runtime 1095692 PR 51457 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095688 Rolling Installer Build and Test coreclr Linux_x64 Release
runtime 1095688 Rolling Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095662 PR 51489 Installer Build and Test coreclr Linux_x64 Release
runtime 1095662 PR 51489 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095579 PR 51488 Installer Build and Test coreclr Linux_x64 Release
runtime 1095579 PR 51488 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095513 PR 50837 Installer Build and Test coreclr Linux_x64 Release
runtime 1095513 PR 50837 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095513 PR 50837 Installer Build and Test coreclr Linux_x64 Release
runtime 1095513 PR 50837 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095478 Rolling Installer Build and Test coreclr Linux_x64 Release
runtime 1095478 Rolling Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095461 PR 51486 Installer Build and Test coreclr Linux_x64 Release
runtime 1095461 PR 51486 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095450 PR 51485 Installer Build and Test coreclr Linux_x64 Release
runtime 1095450 PR 51485 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095450 PR 51485 Installer Build and Test coreclr Linux_x64 Release
runtime 1095450 PR 51485 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095441 PR 49762 Installer Build and Test coreclr Linux_x64 Release
runtime 1095441 PR 49762 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095423 PR 51484 Installer Build and Test coreclr Linux_x64 Release
runtime 1095423 PR 51484 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095418 PR 51483 Installer Build and Test coreclr Linux_x64 Release
runtime 1095418 PR 51483 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095405 PR 49304 Installer Build and Test coreclr Linux_x64 Release
runtime 1095405 PR 49304 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095396 Rolling Installer Build and Test coreclr Linux_x64 Release
runtime 1095396 Rolling Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095378 PR 49762 Installer Build and Test coreclr Linux_x64 Release
runtime 1095378 PR 49762 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095366 PR 50931 Installer Build and Test coreclr Linux_x64 Release
runtime 1095366 PR 50931 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095351 PR 51300 Installer Build and Test coreclr Linux_x64 Release
runtime 1095351 PR 51300 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095315 PR 51479 Installer Build and Test coreclr Linux_x64 Release
runtime 1095315 PR 51479 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095285 PR 51300 Installer Build and Test coreclr Linux_x64 Release
runtime 1095285 PR 51300 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095264 PR 51473 Installer Build and Test coreclr Linux_x64 Release
runtime 1095264 PR 51473 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095195 PR 51462 Installer Build and Test coreclr Linux_x64 Release
runtime 1095195 PR 51462 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095190 PR 51473 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095190 PR 51473 Installer Build and Test coreclr Linux_x64 Release
runtime 1095163 PR 51212 Installer Build and Test coreclr Linux_x64 Release
runtime 1095163 PR 51212 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095148 PR 51469 Installer Build and Test coreclr Linux_x64 Release
runtime 1095148 PR 51469 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095140 PR 50941 Installer Build and Test coreclr Linux_x64 Release
runtime 1095140 PR 50941 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095140 PR 50941 Installer Build and Test coreclr Linux_x64 Release
runtime 1095140 PR 50941 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095103 PR 51440 Installer Build and Test coreclr Linux_x64 Release
runtime 1095103 PR 51440 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095099 PR 51466 Installer Build and Test coreclr Linux_x64 Release
runtime 1095099 PR 51466 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095079 PR 51464 Installer Build and Test coreclr Linux_x64 Release
runtime 1095079 PR 51464 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095068 PR 51462 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1095068 PR 51462 Installer Build and Test coreclr Linux_x64 Release
runtime 1095012 PR 51458 Installer Build and Test coreclr Linux_x64 Release
runtime 1095012 PR 51458 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094995 PR 51457 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094931 PR 51367 Installer Build and Test coreclr Linux_x64 Release
runtime 1094931 PR 51367 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094897 Rolling Installer Build and Test coreclr Linux_x64 Release
runtime 1094897 Rolling Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094875 PR 51454 Installer Build and Test coreclr Linux_x64 Release
runtime 1094875 PR 51454 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094856 PR 51212 Installer Build and Test coreclr Linux_x64 Release
runtime 1094856 PR 51212 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094832 PR 50316 Installer Build and Test coreclr Linux_x64 Release
runtime 1094832 PR 50316 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094816 PR 51296 Installer Build and Test coreclr Linux_x64 Release
runtime 1094816 PR 51296 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094799 PR 51212 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094799 PR 51212 Installer Build and Test coreclr Linux_x64 Release
runtime 1094787 PR 48758 Installer Build and Test coreclr Linux_x64 Release
runtime 1094787 PR 48758 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094772 PR 51212 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094772 PR 51212 Installer Build and Test coreclr Linux_x64 Release
runtime 1094754 PR 51213 Installer Build and Test coreclr Linux_x64 Release
runtime 1094754 PR 51213 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094636 PR 51450 Installer Build and Test coreclr Linux_x64 Release
runtime 1094636 PR 51450 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094632 PR 51446 Installer Build and Test coreclr Linux_x64 Release
runtime 1094632 PR 51446 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094626 Rolling Installer Build and Test coreclr Linux_x64 Release
runtime 1094626 Rolling Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094583 PR 51448 Installer Build and Test coreclr Linux_x64 Release
runtime 1094583 PR 51448 Installer Build and Test coreclr Linux_musl_x64 Release
runtime 1094558 PR 51425 Installer Build and Test coreclr Linux_x64 Release

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
31 48 48
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Diagnostics-coreclr untriaged New issue has not been triaged by the area owner labels Apr 19, 2021
@ghost
Copy link

ghost commented Apr 19, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Creating Tracking Issue (data being generated)

Author: runfoapp[bot]
Assignees: -
Labels:

area-Diagnostics-coreclr, untriaged
Milestone: -

@ghost
Copy link

ghost commented Apr 19, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Creating Tracking Issue (data being generated)

Author: runfoapp[bot]
Assignees: -
Labels:

area-Host, untriaged
Milestone: -

@jkoritzinsky
Copy link
Member

Example build: https://dev.azure.com/dnceng/public/_build/results?buildId=1095811&view=results

cc: @mateoatr

@akoeplinger akoeplinger mentioned this issue Apr 20, 2021
Merged
@mateoatr mateoatr mentioned this issue Apr 20, 2021
Merged
agocke added a commit to agocke/runtime that referenced this issue Apr 22, 2021
@agocke
Fix symbolic link tests
416bc26 
Use IDisposable and `File.Delete` to ensure that symlinks get created
and cleaned up properly on all platforms. If all symlinks aren't
deleted, the later test cleanup phases have problems deleting them.

Fixes dotnet#51502
@agocke agocke mentioned this issue Apr 22, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 22, 2021
@ghost ghost closed this as completed in #51712 Apr 23, 2021
ghost pushed a commit that referenced this issue Apr 23, 2021
@agocke
Fix symbolic link tests (#51712)
ed1897e 
* Fix symbolic link tests

Use IDisposable and `File.Delete` to ensure that symlinks get created
and cleaned up properly on all platforms. If all symlinks aren't
deleted, the later test cleanup phases have problems deleting them.

Fixes #51502

* Test still failing on Mac, skip until I can investigate
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 23, 2021
@jaredpar
Copy link
Member

@agocke This issue is closed but it's still hitting builds.

@agocke
Copy link
Member

agocke commented Apr 23, 2021 •
edited
Loading

The latest build that I can see that it hit according to runfo used the runtime base commit 76dd72b, which is just before this change was merged. Did I miss a newer build that it hit?

@jaredpar
Copy link
Member

Yep. That's right. I misread the dates on the issue and thought it was closed four days ago. Def been hits since then. But actually looking at the right data everything is good here 😄

@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Host untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix symbolic link tests agocke/runtime
3 participants
@jaredpar @agocke @jkoritzinsky