-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster, smaller wasm runtime #51446
Faster, smaller wasm runtime #51446
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Just create a dedicated |
Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar, @CoffeeFlux Issue Details
Trading off code size and performance
Inspired by Is WebAssembly magic performance pixie dust? where they were seeing a x2 perf degradation from
And its currently using
|
Tagging subscribers to this area: @directhex Issue Details
Trading off code size and performance
Inspired by Is WebAssembly magic performance pixie dust? where they were seeing a x2 perf degradation from
And its currently using
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
Trading off code size and performance
Inspired by Is WebAssembly magic performance pixie dust? where they were seeing a x2 perf degradation from
And its currently using
|
Huh, I thought we were already running the closure compiler... I wonder what happened there. Regardless, thanks a bunch for catching that! That's a really nice win on size. Regarding the Oz to O3 change, there has been a fair bit of discussion about this internally. I'd personally like to see another benchmark run to get an idea of the tradeoff here, but ultimately it's up to @lewing. 7K isn't too bad a penalty to pay though, so I think it's worth considering. |
Might split this into different bits as the clousre compiler on |
Opened issue for the |
Is this supposed to get This is pre-existing to your change, but it seems like this Makefile and the Refers to: src/mono/wasm/Makefile:125 in 9113bc9. [](commit_id = 9113bc9, deletion_comment = False) |
-O3
rather than-Oz
for a faster runtime.js
to make up the difference in filesizeTrading off code size and performance
Inspired by Is WebAssembly magic performance pixie dust? where they were seeing a x2 perf degradation from
-Os
:And its currently using
-Oz
which is even worse for performance than-Os