Fix EventSource trimmer warning #51237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…iagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…acing/EventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…into EventSrcWrnFix2
|
Net change is 0? |
eerhardt
reviewed
Apr 14, 2021
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Suppressions.Shared.xml
Show resolved
Hide resolved
sywhang
approved these changes
Apr 14, 2021
vitek-karas
approved these changes
Apr 14, 2021
| @@ -145,6 +145,7 @@ public enum EventOpcode | |||
| Send = 9, | |||
| Receive = 240, | |||
| } | |||
| [System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembersAttribute(System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.All)] | |||
There was a problem hiding this comment.
Do we really need All - is that because of the NestedTypes issue?
(we should fix that then - it's been agreed that we should change the behavior of that already).
|
Opened dotnet/linker#1969 for the likely linker bug. Will not merge until this is understood |
eerhardt
reviewed
Apr 19, 2021
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Show resolved
Hide resolved
agocke
added a commit
to agocke/runtime
that referenced
this pull request
Apr 22, 2021
This fix is necessary for dotnet#51237 to work properly. Otherwise, the linker may crash when analyzing certain patterns.
7 tasks
agocke
pushed a commit
to agocke/runtime
that referenced
this pull request
Apr 22, 2021
* eh fix * test change that inadvertently got checked in earlier * Suppresses the trimmer warning on TypeAnalysis ctor * Incorporating FB * Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Fix DynamicDependency as per PR feedback * an earlier change got reverted * fixed proj file netcore app condition check * fixed NETCORE_ENGINEERING_TELEMETRY build failures * fixeing another NETCORE_ENGINEERING_TELEMETRY build failures * Adding RequiresUnreferencedCode to TypeAnalysis ctor instead of suppressing the warning to get FB, not fully fixed * PR FB and suppressing warnings for safe calls * propagated the warning all the way up * CI build break fix for one file * excluding NativeRTEventSrc from being build in a project * Missed couple of supppressions on NativeRTEventSrc * build break fixes * Trimmer warning fix related to EventSource manifest creation * incorporate fb * fix build break in some configs * comment feedback * build break Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> (cherry picked from commit ddaa1c3)
mmitche
pushed a commit
that referenced
this pull request
Apr 22, 2021
* Include linker fix from dotnet/linker#1972 This fix is necessary for #51237 to work properly. Otherwise, the linker may crash when analyzing certain patterns. * Fix EventSource trimmer warning (#51237) * eh fix * test change that inadvertently got checked in earlier * Suppresses the trimmer warning on TypeAnalysis ctor * Incorporating FB * Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Fix DynamicDependency as per PR feedback * an earlier change got reverted * fixed proj file netcore app condition check * fixed NETCORE_ENGINEERING_TELEMETRY build failures * fixeing another NETCORE_ENGINEERING_TELEMETRY build failures * Adding RequiresUnreferencedCode to TypeAnalysis ctor instead of suppressing the warning to get FB, not fully fixed * PR FB and suppressing warnings for safe calls * propagated the warning all the way up * CI build break fix for one file * excluding NativeRTEventSrc from being build in a project * Missed couple of supppressions on NativeRTEventSrc * build break fixes * Trimmer warning fix related to EventSource manifest creation * incorporate fb * fix build break in some configs * comment feedback * build break Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> (cherry picked from commit ddaa1c3) Co-authored-by: Lakshan Fernando <lakshanf@hotmail.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the trimmer has capability to preserve derived type members, fixed the warning related to manifest generation by preserving all members of EventSource and its derived types