-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EventSource trimmer warning #51237
Merged
Merged
Changes from 58 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
54516c7
eh fix
LakshanF dbe9ca4
Merge remote-tracking branch 'upstream/master'
LakshanF 70e04d7
Merge remote-tracking branch 'upstream/master'
LakshanF f4fc3f8
Merge remote-tracking branch 'upstream/master'
LakshanF ee6401d
Merge remote-tracking branch 'upstream/master'
LakshanF e87f26c
Merge remote-tracking branch 'upstream/master'
LakshanF af6bcb0
Merge remote-tracking branch 'upstream/master'
LakshanF 9cc84c0
Merge remote-tracking branch 'upstream/master'
LakshanF 2f7bc29
Merge remote-tracking branch 'upstream/master'
LakshanF 42eadd3
test change that inadvertently got checked in earlier
LakshanF d4d9e31
Merge remote-tracking branch 'upstream/master'
LakshanF 7317d3c
Merge remote-tracking branch 'upstream/master'
LakshanF f04fb8d
Merge remote-tracking branch 'upstream/master'
LakshanF 3427371
Merge remote-tracking branch 'upstream/master'
LakshanF 5cf8134
Merge branch 'master' of https://github.com/LakshanF/runtime
LakshanF 584e0e3
Merge remote-tracking branch 'upstream/master'
LakshanF 715dcbd
Merge branch 'master' of https://github.com/LakshanF/runtime
LakshanF 8dab23e
Merge remote-tracking branch 'upstream/master'
LakshanF 56fcb12
Merge branch 'master' of https://github.com/LakshanF/runtime
LakshanF 7679b91
Merge remote-tracking branch 'upstream/master'
LakshanF 1fdfdbf
Merge remote-tracking branch 'upstream/master'
LakshanF f50c6f9
Merge branch 'master' of https://github.com/LakshanF/runtime
LakshanF db9be82
Suppresses the trimmer warning on TypeAnalysis ctor
LakshanF b623513
Incorporating FB
LakshanF 045e38d
Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/D…
LakshanF a9dda65
Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/D…
LakshanF 4ccd2ae
Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tr…
LakshanF ea460c3
Fix DynamicDependency as per PR feedback
LakshanF 31667cf
Merge branch 'EventSrcWrnFix2' of https://github.com/LakshanF/runtime…
LakshanF 3e56d85
an earlier change got reverted
LakshanF aa2a21d
fixed proj file netcore app condition check
LakshanF 3d61a44
fixed NETCORE_ENGINEERING_TELEMETRY build failures
LakshanF 5775e1a
fixeing another NETCORE_ENGINEERING_TELEMETRY build failures
LakshanF f1d3a1b
Adding RequiresUnreferencedCode to TypeAnalysis ctor instead of suppr…
LakshanF 589ee3f
PR FB and suppressing warnings for safe calls
LakshanF bb4a18d
propagated the warning all the way up
LakshanF 024c8d6
CI build break fix for one file
LakshanF 7dd337f
Merge branch 'main' into EventSrcWrnFix2
LakshanF 6d51f12
excluding NativeRTEventSrc from being build in a project
LakshanF bfd3bc3
Merge branch 'EventSrcWrnFix2' of https://github.com/LakshanF/runtime…
LakshanF 0540809
Missed couple of supppressions on NativeRTEventSrc
LakshanF f0ca444
build break fixes
LakshanF a3808fe
Merge remote-tracking branch 'upstream/main' into main
LakshanF ca38974
Merge remote-tracking branch 'upstream/main' into main
LakshanF bcc0670
Merge remote-tracking branch 'upstream/main' into main
LakshanF bcde531
Merge remote-tracking branch 'upstream/main' into main
LakshanF d09d490
Merge remote-tracking branch 'upstream/main' into main
LakshanF 30be374
Merge remote-tracking branch 'upstream/main' into main
LakshanF 6bd2eab
Merge branch 'main' of https://github.com/LakshanF/runtime into main
LakshanF ae2a13a
Merge remote-tracking branch 'upstream/main' into main
LakshanF 376e596
Merge remote-tracking branch 'upstream/main' into main
LakshanF 8bfe839
Merge branch 'main' of https://github.com/LakshanF/runtime into main
LakshanF d438923
Merge remote-tracking branch 'upstream/main' into main
LakshanF 9525a71
Merge remote-tracking branch 'upstream/main' into main
LakshanF f6c6cfe
Merge remote-tracking branch 'upstream/main' into main
LakshanF b79705e
Merge remote-tracking branch 'upstream/main' into main
LakshanF a91e900
Trimmer warning fix related to EventSource manifest creation
LakshanF 86ce794
incorporate fb
LakshanF 2fd2f6f
fix build break in some configs
LakshanF b9d9622
Merge branch 'main' of https://github.com/dotnet/runtime into EventSr…
LakshanF 505d553
Merge branch 'main' of https://github.com/dotnet/runtime into EventSr…
LakshanF a87e452
comment feedback
LakshanF 1790705
build break
LakshanF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need
All
- is that because of the NestedTypes issue?(we should fix that then - it's been agreed that we should change the behavior of that already).