Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some DI code #54732

Merged
merged 1 commit into from
Jun 26, 2021
Merged

Clean up some DI code #54732

merged 1 commit into from
Jun 26, 2021

Conversation

davidfowl
Copy link
Member

  • Remove empty CreateInstanceCallSite file
  • Removed ServiceScopeFactoryCallsite and used ConstantCallsite instead.
  • Added fast path if the value is already cached on the callsite.

- Remove empty CreateInstanceCallSite file
- Removed ServiceScopeFactoryCallsite and used ConstantCallsite instead.
- Added fast path if the value is already cached on the callsite.
@ghost
Copy link

ghost commented Jun 25, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Remove empty CreateInstanceCallSite file
  • Removed ServiceScopeFactoryCallsite and used ConstantCallsite instead.
  • Added fast path if the value is already cached on the callsite.
Author: davidfowl
Assignees: -
Labels:

area-Extensions-DependencyInjection

Milestone: -

@davidfowl davidfowl requested a review from pakrym June 25, 2021 08:21
@davidfowl davidfowl requested a review from eerhardt June 25, 2021 08:22
@davidfowl
Copy link
Member Author

/azp list

@davidfowl
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member Author

/azp run runtime-dev-innerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member Author

/azp run runtime-staging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member Author

/azp run dotnet-linker-tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member Author

Test failures are unrelated. SocketsHttpHandler test timing out, mono interpreter test with System.Security.Cryptography.Xml.Tests are crashing.

@davidfowl davidfowl merged commit c7e37b1 into main Jun 26, 2021
@eerhardt eerhardt deleted the davidfowl/di-cleanup branch June 27, 2021 14:00
@kunalspathak
Copy link
Member

Perf regression in arm64: DrewScoggins/performance-2#7130

@kunalspathak
Copy link
Member

Perf improvements in arm64: DrewScoggins/performance-2#7137

@davidfowl
Copy link
Member Author

So it both regressed and improved performance. I like it.

@kunalspathak
Copy link
Member

Are the regressions expected?

@davidfowl
Copy link
Member Author

No, I'm not sure why it regressed.

@davidfowl
Copy link
Member Author

My guess is that this change #55340 fixed the regression.

@kunalspathak
Copy link
Member

Looks to be the case:
image

@davidfowl
Copy link
Member Author

Excellent

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants