Fix NullReferenceException in background thread emitting IL in Depend… #55340
Conversation
…encyInjection When ILEmitResolverBuilder is getting created, it grabs the "Root" scope off of the ServiceProvider. However, the Root scope isn't set on ServiceProvider yet. So later when it tries to get used, it null refs. But this exception gets caught an eaten since it happens on a background thread. The fix is to set Root before creating the ServiceProviderEngine.
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue Details…encyInjection When ILEmitResolverBuilder is getting created, it grabs the "Root" scope off of the ServiceProvider. However, the Root scope isn't set on ServiceProvider yet. So later when it tries to get used, it null refs. But this exception gets caught an eaten since it happens on a background thread. The fix is to set Root before creating the ServiceProviderEngine.
|
|
I'm betting this it the cause of the performance regression on ARM. |
src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceProvider.cs
Show resolved
Hide resolved
|
What do you think about adding a Debug.Assert to https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/DynamicServiceProviderEngine.cs#L39 ? |
…nd compilation thread
|
|
ghost
locked as resolved and limited conversation to collaborators
…encyInjection
When ILEmitResolverBuilder is getting created, it grabs the "Root" scope off of the ServiceProvider. However, the Root scope isn't set on ServiceProvider yet. So later when it tries to get used, it null refs. But this exception gets caught an eaten since it happens on a background thread.
The fix is to set Root before creating the ServiceProviderEngine.
See description of the issue in #55255 (comment).