Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Remove AppContext switch from S.N.Quic #56027

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Jul 20, 2021

AppContext switch for H/3 scoped down to S.N.Http only. S.N.Quic doesn't have any extra guards ATM.

@karelz Could you please help with servicing?

cc: @davidfowl

@ghost
Copy link

ghost commented Jul 20, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: ManickaP
Assignees: -
Labels:

area-System.Net

Milestone: -

@ManickaP ManickaP changed the title mapichov/quic remove switch [QUIC] Remove AppContext switch from S.N.Quic Jul 20, 2021
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ManickaP
Copy link
Member Author

Failure is disabled test in #55957

@ManickaP ManickaP merged commit 1a84b29 into dotnet:main Jul 21, 2021
@ManickaP ManickaP deleted the mapichov/quic_remove_switch branch July 21, 2021 08:24
@ManickaP
Copy link
Member Author

/backport to release/6.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/6.0-preview7: https://github.com/dotnet/runtime/actions/runs/1051826468

@karelz karelz added this to the 6.0.0 milestone Jul 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants