Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use updated fedora image with msquic #55424

Merged
merged 2 commits into from
Jul 12, 2021
Merged

use updated fedora image with msquic #55424

merged 2 commits into from
Jul 12, 2021

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jul 9, 2021 

[helixbot@6e230f7158c4 /]$ rpm -qa| grep quic
libmsquic-1.5.0-1.x86_64

this should light up System.Net.Quic tests with MsQuic

cc: @safern @MattGal

@wfurt wfurt requested review from ManickaP and a team July 9, 2021 18:55
@wfurt wfurt self-assigned this Jul 9, 2021
@ghost
Copy link

ghost commented Jul 9, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details 
[helixbot@6e230f7158c4 /]$ rpm -qa| grep quic
libmsquic-1.5.0-1.x86_64

this should light up System.Net.Quic tests with MsQuic

cc: @safern @MattGal

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic
Milestone: -

ManickaP
ManickaP approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

safern
safern approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems like there are some networking test failures.

@wfurt wfurt merged commit 6ece5d3 into dotnet:main Jul 12, 2021
@wfurt wfurt deleted the fedoraQuic branch July 12, 2021 03:17
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@ManickaP ManickaP ManickaP approved these changes

Assignees

@wfurt wfurt

Labels
area-System.Net.Quic
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wfurt @ManickaP @safern @karelz