-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix string comparison with ordinal casing with Surrogates #55771
Fix string comparison with ordinal casing with Surrogates #55771
Conversation
Tagging subscribers to this area: @tarekgh, @safern Issue DetailsThis change is fixing the string comparisons with ordinal casing when using surrogate pairs. .NET 6.0 Before changes
.NET 6.0 After changes
|
CC @safern No rush for this one :-) |
src/libraries/System.Private.CoreLib/src/System/Globalization/OrdinalCasing.Icu.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/OrdinalCasing.Icu.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @safern |
This change is fixing the string comparisons with ordinal casing when using surrogate pairs.
I have measured the perf for ordinal casing comparisons in general to ensure there is no regression introduced because of this change.
.NET 6.0 Before changes
.NET 6.0 After changes