ILLink annotations related to ISerializable and IBindingListView in System.Data.Common #55394
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @roji, @ajcvickers Issue DetailsPer offline conversations ISerializable related warnings will be suppressed since adding RUC on them would require also adding RUC on the interface or on all ctors of the class which would cause many unnecessary warnings.
|
| @@ -268,6 +268,8 @@ protected DataSet(SerializationInfo info, StreamingContext context, bool Constru | |||
| DeserializeDataSet(info, context, remotingFormat, schemaSerializationMode); | |||
| } | |||
|
|
|||
| [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode", | |||
| Justification = "Binary serialization is unsafe in general and is planned to be obsoleted. We do not want to mark interface or ctors of this class as unsafe as that would show many unnecessary warnings elsewhere.")] | |||
There was a problem hiding this comment.
@vitek-karas @MichalStrehovsky @marek-safar - are you OK with these suppressions? According to https://github.com/dotnet/designs/blob/main/accepted/2020/better-obsoletion/binaryformatter-obsoletion.md#entirety-of-binaryformatter-type-obsolete-as-warning, these GetObjectData methods are scheduled for obsoletion in .NET 7, along with ISerializable. So going through the work of marking ISerializable.GetObjectData as [RUC] just doesn't seem worth it right now.
There was a problem hiding this comment.
Spoke with Eric offline about this. Just to clarify: ISerializable is distinct from BinaryFormatter, though the two are commonly used together. Our primary focus is on removing BinaryFormatter from the ecosystem. That doc also talks about removing ISerializable from the ecosystem, but there's less immediate urgency around this, so the timelines might not match up 100%.
Regardless, I think suppressing this is the right move for now. 👍
ghost
locked as resolved and limited conversation to collaborators
Per offline conversations ISerializable related warnings will be suppressed since adding RUC on them would require also adding RUC on the interface or on all ctors of the class which would cause many unnecessary warnings and binary serialization is about to be obsoleted anyway and is unsafe regardless of trimming.