Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ReflectionOnly as data contract serializer option for iOS/tvOS/MacCatalyst #55503

Merged
merged 6 commits into from
Jul 13, 2021
Merged

Use ReflectionOnly as data contract serializer option for iOS/tvOS/MacCatalyst #55503

merged 6 commits into from
Jul 13, 2021

Conversation

MaximLipnin
Copy link
Contributor

@MaximLipnin MaximLipnin commented Jul 12, 2021 •
edited
Loading

An attempt to address #47114 by making the System.Runtime.Serialization.DataContractSerializer.Option property return ReflectionOnly value when RuntimeFeature.IsDynamicCodeSupported is true.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@runfoapp runfoapp bot mentioned this pull request Jul 13, 2021
Closed
@MaximLipnin MaximLipnin marked this pull request as ready for review July 13, 2021 10:27
steveisok
steveisok approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I know the iOS/tvOS/Catalyst test failures are unrelated. Can you address them separately?

@MaximLipnin MaximLipnin merged commit 38c187a into dotnet:main Jul 13, 2021
@MaximLipnin MaximLipnin deleted the jit_compile_method_in_aot_on_ios branch July 13, 2021 13:16
@MaximLipnin MaximLipnin mentioned this pull request Jul 13, 2021
Closed
@filipnavara
Copy link
Member

Thanks!

@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@danmoseley danmoseley mentioned this pull request Aug 11, 2021
Open
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@steveisok steveisok steveisok approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@filipnavara filipnavara filipnavara approved these changes

@directhex directhex Awaiting requested review from directhex

@mdh1418 mdh1418 Awaiting requested review from mdh1418

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MaximLipnin @filipnavara @steveisok @akoeplinger @jkotas