Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filtering ObjectAllocated callback for pinned object heap allocation only #55448

Merged

Conversation

Yauk
Copy link
Contributor

@Yauk Yauk commented Jul 10, 2021

Fixes #53134

In ICorProfiler, we can have the runtime to notify the profiler when an object is allocated on the large object heap only. We should have a similar option for the pinned object heap. This PR is to fill this gap and add support ObjectAllocated callback for pinned object heap allocation.

@ghost
Copy link

ghost commented Jul 10, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

In ICorProfiler, we can have the runtime to notify the profiler when an object is allocated on the large object heap only. We should have a similar option for the pinned object heap. This PR is to fill this gap and add support ObjectAllocated callback for pinned object heap allocation.

Author: Yauk
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@dnfadmin
Copy link

dnfadmin commented Jul 10, 2021

CLA assistant check
All CLA requirements met.

@cshung cshung requested a review from davmason July 10, 2021 05:17
Copy link
Member

@davmason davmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cshung cshung changed the title Private/20210608 prototype allocation profiler Support filtering ObjectAllocated callback for pinned object heap allocation only Jul 10, 2021
@cshung cshung merged commit fce412b into dotnet:main Jul 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support filtering ObjectAllocated callback for pinned object heap allocation only
4 participants