Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NRE in EncodingProvider #55238

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Fix NRE in EncodingProvider #55238

merged 2 commits into from
Jul 8, 2021

Conversation

SergeiPavlov
Copy link
Contributor

@SergeiPavlov SergeiPavlov commented Jul 6, 2021 •
edited
Loading

Issue #55233

Add provider into array copy newProviders instead of original array before assigning array copy to s_providers

@ghost
Copy link

ghost commented Jul 6, 2021

Tagging subscribers to this area: @tarekgh, @krwq, @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Issue #55233

Add provider into array copy newProviders instead of origonal array befor assigning array copy to s_providers

Author: SergeiPavlov
Assignees: -
Labels:

area-System.Text.Encoding
Milestone: -

tarekgh
tarekgh approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SergeiPavlov for fixing this issue. LGTM.

@stephentoub
Copy link
Member

Thanks for finding and fixing. Could you add a test as well?

@stephentoub
Copy link
Member

I pushed a commit with a test.

@dnfadmin
Copy link

dnfadmin commented Jul 8, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@stephentoub stephentoub merged commit 89d23da into dotnet:main Jul 8, 2021
@SergeiPavlov SergeiPavlov mentioned this pull request Jul 8, 2021
Closed
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@tarekgh tarekgh tarekgh approved these changes

Assignees
No one assigned
Labels
area-System.Text.Encoding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergeiPavlov @stephentoub @dnfadmin @tarekgh