Use more string interpolation #55738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I previously did a pass looking for opportunities. Finding a few more, as well as fixing some misuse of existing methods.
halgab
reviewed
Jul 15, 2021
src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs
Outdated
Show resolved
Hide resolved
…oTests.cs Co-authored-by: halgab <24685886+halgab@users.noreply.github.com>
jkotas
approved these changes
Jul 15, 2021
src/libraries/System.Linq.Expressions/tests/ILReader/FormatProvider.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Linq.Expressions/tests/ILReader/FormatProvider.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlDictionaryWriter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Web.HttpUtility/src/System/Web/HttpUtility.cs
Outdated
Show resolved
Hide resolved
| @@ -168,7 +168,7 @@ internal long CreationTime | |||
|
|
|||
| private static string? s_instanceIdentifier; | |||
| internal static string InstanceIdentifier => | |||
| LazyInitializer.EnsureInitialized(ref s_instanceIdentifier, ref s_classSyncObject, () => Guid.NewGuid().ToString() + ":"); | |||
| LazyInitializer.EnsureInitialized(ref s_instanceIdentifier, ref s_classSyncObject, () => $"{Guid.NewGuid()}:"); | |||
|
|
|||
| // Double-checked locking pattern requires volatile for read/write synchronization | |||
| private volatile bool _traceIdentifierInited; | |||
There was a problem hiding this comment.
String formatting using Convert.ToString a few lines below can use cleanup as well.
There was a problem hiding this comment.
Thanks. Looks like there's another handful of call sites. I'll merge this one and address Convert.ToString in a subsequent PR.
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously did a pass looking for opportunities. Finding a few more, as well as fixing some misuse of existing methods.