Handle nullable primitives before passing them to WritePrimitive… #54800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h expects non-null values.
stephentoub
approved these changes
Jul 9, 2021
HongGit
approved these changes
Jul 12, 2021
mconnew
approved these changes
Jul 12, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle nullable primitives before passing them to WritePrimitive which expects non-null values.
XmlSerializer's
WritePrimitivemethod is written to expect non-null values.But primitive types can be nullable, and can be expected to be nullable in
serialization. This fix will check for a null primitive value before passing off to
WritePrimitivesince null primitives are a simple null tag to write.Fixes #421