Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing extra jit flag dump entries #55280

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

AndyAyersMS
Copy link
Member

Fix missing flag entries that are displayed in various contexts, eg mcs -jitflags

Before:

Individual Flag Appearances
   ...
   23587   54.18%  TIER0
   15818   36.34%  TIER1
    9531   21.89%  Unknown jit flags-0400000000000000
    1725    3.96%  Unknown jit flags-0800000000000000
     489    1.12%  HAS_LIKELY_CLASS
    2927    6.72%  HAS_CLASS_PROFILE
   11256   25.86%  HAS_EDGE_PROFILE
   11256   25.86%  HAS_PGO

After:

Individual Flag Appearances
   ...
   23587   54.18%  TIER0
   15818   36.34%  TIER1
    9531   21.89%  HAS_DYNAMIC_PROFILE
    1725    3.96%  HAS_STATIC_PROFILE
     489    1.12%  HAS_LIKELY_CLASS
    2927    6.72%  HAS_CLASS_PROFILE
   11256   25.86%  HAS_EDGE_PROFILE
   11256   25.86%  HAS_PGO

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 7, 2021
@AndyAyersMS
Copy link
Member Author

cc @dotnet/jit-contrib

@AndyAyersMS
Copy link
Member Author

One infra issue (installer), one unrelated test failure that seems like an instance of #54941.

    Common.Tests.cgroupsTests.ValidateFindCGroupVersion [FAIL]
      System.TypeLoadException : GenericArguments[0], 'System.Int32', on 'System.IBinaryInteger`1[TSelf]' violates the constraint of type parameter 'TSelf'.
      Stack Trace:
        /_/src/libraries/Common/tests/Tests/Interop/cgroupsTests.cs(14,0): at Common.Tests.cgroupsTests.ValidateFindCGroupVersion()

@AndyAyersMS AndyAyersMS merged commit f30c848 into dotnet:main Jul 8, 2021
@AndyAyersMS AndyAyersMS deleted the FixExtraJitFlagsDump branch July 8, 2021 16:50
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants