Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more alloc-dealloc mismatches and use-after-scopes #55420

Merged
7 commits merged into from
Jul 12, 2021

Conversation

jkoritzinsky
Copy link
Member

Fix another dynamically-sized allocation to use new/delete instead of the mismatched new[]/delete.

Move another local up a scope.

Use a simple new[]/delete[] instead of casting.

Discovered in #54580

@jkoritzinsky jkoritzinsky added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI area-VM-coreclr labels Jul 9, 2021
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@ghost
Copy link

ghost commented Jul 9, 2021

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 1509b1a into dotnet:main Jul 12, 2021
@jkoritzinsky jkoritzinsky deleted the asan-fixes-2 branch July 12, 2021 22:56
@ghost ghost locked as resolved and limited conversation to collaborators Aug 11, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI area-VM-coreclr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants