Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternatives to redirecting threads via IP changes in the context, for a few cases on Windows #55649

Merged
merged 6 commits into from
Jul 15, 2021

Conversation

kouvel
Copy link
Member

@kouvel kouvel commented Jul 14, 2021

  • For GC/debugger suspension, a new variant of an APC is used to interrupt the thread
  • For hardware exceptions, an exception is raised from the vectored exception handler instead of redirecting and then raising an exception
  • Made changes to enable /guard:ehcont and /cetcompat for binaries, but commented out the enablement for now since it looks like we will first need .pgd files generated with /guard:ehcont and published for release builds to succeed

@kouvel kouvel added this to the 6.0.0 milestone Jul 14, 2021
@kouvel kouvel requested a review from janvorli July 14, 2021 15:23
@kouvel kouvel self-assigned this Jul 14, 2021
…, for a few cases on Windows

- For GC/debugger suspension, a new variant of an APC is used to interrupt the thread
- For hardware exceptions, an exception is raised from the vectored exception handler instead of redirecting and then raising an exception
- Made changes to enable /guard:ehcont and /cetcompat for binaries, but commented out the enablement for now since it looks like we will first need .pgd files generated with /guard:ehcont and published for release builds to succeed
src/coreclr/vm/threads.cpp Outdated Show resolved Hide resolved
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kouvel kouvel merged commit 663013d into dotnet:main Jul 15, 2021
@kouvel kouvel deleted the UseApc branch July 15, 2021 16:34
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants