Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax chain status for building an invalid chain. #55231

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Relax chain status for building an invalid chain. #55231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,11 +988,17 @@ void CheckChain()
// Clear UntrustedRoot, if it happened.
allFlags &= ~X509ChainStatusFlags.UntrustedRoot;

Assert.Equal(
X509ChainStatusFlags.NotSignatureValid,
allFlags);

Assert.Equal(3, chain.ChainElements.Count);
// The chain result can either be PartialChain or NotSignatureValid.
// If the flags are PartialChain, then move on.
// If the flags are not PartialChain, we make sure the result is
// NotSignatureValid.
// In the case of PartialChain, we don't care how many certificates
// are in the chain.
if (allFlags != X509ChainStatusFlags.PartialChain)
{
Assert.Equal(X509ChainStatusFlags.NotSignatureValid, allFlags);
Assert.Equal(3, chain.ChainElements.Count);
}

Assert.False(valid, $"Chain is valid on execution {iter}");
}
Expand Down