update MsQuic version #55291
Merged
update MsQuic version #55291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
CarnaViire
reviewed
Jul 7, 2021
| @@ -4,7 +4,7 @@ | |||
| <Uri>https://github.com/dotnet/icu</Uri> | |||
| <Sha>e7626ad8c04b150de635f920b5e8dede0aafaf73</Sha> | |||
| </Dependency> | |||
| <Dependency Name="System.Net.MsQuic.Transport" Version="6.0.0-preview.7.21328.2"> | |||
| <Dependency Name="System.Net.MsQuic.Transport" Version="6.0.0-preview.7.21357.1"> | |||
There was a problem hiding this comment.
Is it ok that <Sha> wasn't changed?
There was a problem hiding this comment.
I think so but I'm not 100% cc: @safern
I think the sha is updated when this update is done with darc/maestro.
I did build/restore and I see new version restored in Nuget cache.
There was a problem hiding this comment.
Yeah the sha is updated by darc/maestro. However you can also update it manually yourself, but it is not a deal breaker if we don't do it.
Merged
safern
approved these changes
Jul 7, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did ~300 runs with updated MsQuic and AcceptStream_ConnectionAborted_ByClient_Throws looks stable.
fixes #55242
contributes to #49157
thanks @nibanks for the updates.