Enable WASM AOT microbenchmark run #55353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…t time. Adjust -aotcompilermode format to "--aotcompilermode=wasm".
…t time. Adjust -aotcompilermode format to "--aotcompilermode=wasm".
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
…m/dnceng/internal/_git/dotnet-runtime into alicial/WASMAOTMicrobenchmarks
2 tasks
Lxiamail
commented
Aug 4, 2021
| payload_directory= | ||
| workitem_directory=$source_directory | ||
| performance_directory=$workitem_directory | ||
| setup_arguments="--perf-hash $commit_sha $common_setup_arguments" | ||
| else | ||
| git clone --branch main --depth 1 --quiet https://github.com/dotnet/performance $performance_directory | ||
| echo "Not running from perf repo" |
There was a problem hiding this comment.
Before this PR merge, should revert back to the original code to clone main branch once PR dotnet/performance#1902 is merged
Lxiamail
requested review from
imhameed,
lambdageek,
SamMonoRT and
vargaz
as code owners
DrewScoggins
approved these changes
Aug 4, 2021
| @@ -228,7 +234,11 @@ if [[ "$mono_dotnet" != "" ]] && [[ "$monointerpreter" == "false" ]]; then | |||
| fi | |||
|
|
|||
| if [[ "$wasm_runtime_loc" != "" ]]; then | |||
| configurations="CompilationMode=wasm RunKind=$kind" | |||
| if [[ "$wasmaot" == "true" ]]; then | |||
| configurations="CompilationMode=wasm AOT=true RunKind=$kind" | |||
There was a problem hiding this comment.
AOT -> MonoAOT to match the current configs we have.
There was a problem hiding this comment.
Is MonoAOT different from wasm aot?
| @@ -254,8 +264,10 @@ if [[ "$run_from_perf_repo" = true ]]; then | |||
| performance_directory=$workitem_directory | |||
| setup_arguments="--perf-hash $commit_sha $common_setup_arguments" | |||
| else | |||
| git clone --branch main --depth 1 --quiet https://github.com/dotnet/performance $performance_directory | |||
|
|
|||
| git clone --branch alicial/wasmaotmicro --depth 1 https://github.com/dotnet/performance.git $performance_directory | |||
There was a problem hiding this comment.
This needs to switch back to cloning from the performance repo.
| # install emsdk, $source_directory/src/mono/wasm/ has the nuget.config with require feed. EMSDK may be available in the payload in a different directory, should visit this install to avoid deplicated payload. | ||
| pushd $source_directory/src/mono/wasm/ | ||
| make provision-wasm | ||
| EMSDK_PATH = $source_directory/src/mono/wasm/emsdk |
There was a problem hiding this comment.
This variable gets set, but it does not ever seem to get used anywhere. What is it for?
There was a problem hiding this comment.
Yes, EMSDK_PATH is not used in our script file. It is set here is per document guidance at https://github.com/dotnet/runtime/blob/d953229d5429d2ffde833740dd481aab864d3e0c/src/mono/wasm/README.md
Lxiamail
force-pushed
the
alicial/WASMAOTMicrobenchmarks
branch
2 times, most recently
from
0e95ec4
to
dd43fca
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.