Enable WASM AOT microbenchmark run #55353
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule performance
added at
522aa7
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,6 +124,10 @@ while (($# > 0)); do | |
| wasm_runtime_loc=$2 | ||
| shift 2 | ||
| ;; | ||
| --wasmaot) | ||
| wasmaot=true | ||
| shift 1 | ||
| ;; | ||
| --compare) | ||
| compare=true | ||
| shift 1 | ||
|
|
@@ -158,6 +162,7 @@ while (($# > 0)); do | |
| echo " --internal If the benchmarks are running as an official job." | ||
| echo " --monodotnet Pass the path to the mono dotnet for mono performance testing." | ||
| echo " --wasm Path to the unpacked wasm runtime pack." | ||
| echo " --wasmaot Indicate wasm aot" | ||
| echo " --latestdotnet --dotnet-versions will not be specified. --dotnet-versions defaults to LKG version in global.json " | ||
| echo " --alpine Set for runs on Alpine" | ||
| echo "" | ||
|
|
@@ -184,6 +189,7 @@ fi | |
|
|
||
| payload_directory=$source_directory/Payload | ||
| performance_directory=$payload_directory/performance | ||
| benchmark_directory=$payload_directory/BenchmarkDotNet | ||
| workitem_directory=$source_directory/workitem | ||
| extra_benchmark_dotnet_arguments="--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --stopOnFirstError true" | ||
| perflab_arguments= | ||
|
|
@@ -228,7 +234,11 @@ if [[ "$mono_dotnet" != "" ]] && [[ "$monointerpreter" == "false" ]]; then | |
| fi | ||
|
|
||
| if [[ "$wasm_runtime_loc" != "" ]]; then | ||
| if [[ "$wasmaot" == "true" ]]; then | ||
| configurations="CompilationMode=wasm AOT=true RunKind=$kind" | ||
| else | ||
| configurations="CompilationMode=wasm RunKind=$kind" | ||
| fi | ||
| if [[ "$javascript_engine" == "javascriptcore" ]]; then | ||
| configurations="$configurations JSEngine=javascriptcore" | ||
| fi | ||
|
|
@@ -249,12 +259,18 @@ common_setup_arguments="--channel main --queue $queue --build-number $build_numb | |
| setup_arguments="--repository https://github.com/$repository --branch $branch --get-perf-hash --commit-sha $commit_sha $common_setup_arguments" | ||
|
|
||
| if [[ "$run_from_perf_repo" = true ]]; then | ||
| echo "Running from perf repo" | ||
| payload_directory= | ||
| workitem_directory=$source_directory | ||
| performance_directory=$workitem_directory | ||
| setup_arguments="--perf-hash $commit_sha $common_setup_arguments" | ||
| else | ||
| echo "Not running from perf repo" | ||
|
There was a problem hiding this comment. Before this PR merge, should revert back to the original code to clone main branch once PR dotnet/performance#1902 is merged |
||
| git clone --branch alicial/wasmaotmicro --depth 1 https://github.com/dotnet/performance.git $performance_directory | ||
|
There was a problem hiding this comment. This needs to switch back to cloning from the performance repo. |
||
| # uncomment to use BenchmarkDotNet sources instead of nuget packages | ||
| # git clone https://github.com/dotnet/BenchmarkDotNet.git $benchmark_directory | ||
|
|
||
| ls $payload_directory | ||
|
|
||
| docs_directory=$performance_directory/docs | ||
| mv $docs_directory $workitem_directory | ||
|
|
@@ -264,7 +280,21 @@ if [[ "$wasm_runtime_loc" != "" ]]; then | |
| using_wasm=true | ||
| wasm_dotnet_path=$payload_directory/dotnet-wasm | ||
| mv $wasm_runtime_loc $wasm_dotnet_path | ||
| pushd $source_directory/src/mono/wasm/ | ||
| make provision-wasm | ||
| EMSDK_PATH = $source_directory/src/mono/wasm/emsdk | ||
|
There was a problem hiding this comment. This variable gets set, but it does not ever seem to get used anywhere. What is it for? There was a problem hiding this comment. Yes, EMSDK_PATH is not used in our script file. It is set here is per document guidance at https://github.com/dotnet/runtime/blob/d953229d5429d2ffde833740dd481aab864d3e0c/src/mono/wasm/README.md |
||
| popd | ||
| # wasm aot and interpreter need some source code from dotnet\runtime repo | ||
| rsync -aq --progress $source_directory/* $wasm_dotnet_path --exclude Payload --exclude docs --exclude src/coreclr --exclude src/tests --exclude artifacts/obj --exclude artifacts/log --exclude artifacts/tests --exclude __download__ | ||
| # install EMSDK if $EMSDK_PATH is not Set. EMSDK may be available in the payload in a different directory, should visit this install to avoid deplicated payload. | ||
| # copy wasm build drop to the location that aot and interpreter build expects | ||
| rsync -a --progress $wasm_dotnet_path/artifacts/BrowserWasm/artifacts/* $wasm_dotnet_path/artifacts | ||
| rm -r $wasm_dotnet_path/artifacts/BrowserWasm/artifacts | ||
| if [[ "$wasmaot" == "true" ]]; then | ||
| extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine /home/helixbot/.jsvu/$javascript_engine --aotcompilermode wasm --runtimeSrcDir \$HELIX_CORRELATION_PAYLOAD/dotnet-wasm --buildTimeout 3600 --keepfiles" | ||
|
There was a problem hiding this comment. Make sure that --keep-files is removed |
||
| else | ||
| extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine /home/helixbot/.jsvu/$javascript_engine --runtimeSrcDir \$HELIX_CORRELATION_PAYLOAD/dotnet-wasm --buildTimeout 3600 --keepfiles" | ||
| fi | ||
| fi | ||
|
|
||
| if [[ "$mono_dotnet" != "" ]] && [[ "$monoaot" == "false" ]]; then | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AOT -> MonoAOT to match the current configs we have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is MonoAOT different from wasm aot?