JIT: work around issue with GDV and Boxing #56126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a call is a GDV candidate and returns a struct via hidden buffer, and that return value is immediately boxed, the GDV expansion will produce IR in incorrect order, leading to bad codegen. This seems to be a rare enough sequence that disabling GDV is a reasonable workaround for now. Actually the box expansion is producing IR in the wrong order and GDV fails to fix the order (unlike inlining, which does fix the order). Longer term we should avoid producing out of order IR. But that seems a bit more complicated and may have other CQ impact. Added a test case. Closes dotnet#53549.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@EgorBo PTAL Not thrilled with dropping GDV for some call sites, but doing this avoids the problem, and the number of cases where we see this pattern is likely pretty small. No diffs in SPMI (other fix attempts had ~100's of diffs in asp.net). Also I'm able to run libraries xunit test harness under tiered PGO without odd errors. |
EgorBo
approved these changes
Jul 22, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a call is a GDV candidate and returns a struct via hidden buffer, and that
return value is immediately boxed, the GDV expansion will produce IR in
incorrect order, leading to bad codegen.
This seems to be a rare enough sequence that disabling GDV is a reasonable
workaround for now.
Actually the box expansion is producing IR in the wrong order and GDV fails
to fix the order (unlike inlining, which does fix the order).
Longer term we should avoid producing out of order IR. But that seems a bit
more complicated and may have other CQ impact.
Added a test case.
Closes #53549.