Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: work around issue with GDV and Boxing #56126

Merged
merged 1 commit into from
Jul 22, 2021

Commits on Jul 22, 2021

  1. JIT: work around issue with GDV and Bboxing

    If a call is a GDV candidate and returns a struct via hidden buffer, and that
    return value is immediately boxed, the GDV expansion will produce IR in
    incorrect order, leading to bad codegen.
    
    This seems to be a rare enough sequence that disabling GDV is a reasonable
    workaround for now.
    
    Actually the box expansion is producing IR in the wrong order and GDV fails
    to fix the order (unlike inlining, which does fix the order).
    
    Longer term we should avoid producing out of order IR. But that seems a bit
    more complicated and may have other CQ impact.
    
    Added a test case.
    
    Closes dotnet#53549.
    AndyAyersMS committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    10d4ca9 View commit details
    Browse the repository at this point in the history