-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libraries] Skip test suites crashing on CI for iOS/tvOS/MacCatalyst #57208
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsThe suites for x64 all do not crash locally. Run on CI to see if this is a CI specific crash.
|
97b0740
to
dc2149a
Compare
9c4efdd
to
5f1d3ba
Compare
3b24e89
to
f8854ff
Compare
8/30 CI Completion After having skipped the failing tests in 8/27 run and adopting the Android trampoline settings. Going to double the settings for trampoine for iOS/MacCatalyst/tvOSCrashed SuitesAndroid x64 - NONE Android x86 - NONE iOSSim arm64
iOSSim x64
MacCatalyst arm64
MacCatalyst x64
tvOSSim x64
Test FailuresAndroid x64 Android x86 iOSSim arm64 - NONE iOSSim x64 - NONE MacCatalyst arm64 MacCatalyst x64 - NONE tvOSSim x64 - NONE |
8/30 2nd CI Completion After having skipped the failing tests in 8/30 run and doubling the Android trampoline settings. It seems like trampolines might not be the problem here, so will skip these test suites instead.Crashed SuitesAndroid x64 - NONE Android x86 - NONE iOSSim arm64
iOSSim x64
MacCatalyst arm64
MacCatalyst x64
tvOSSim x64
Test FailuresAndroid x64 - NONE Android x86 - NON iOSSim arm64 iOSSim x64 MacCatalyst arm64 MacCatalyst x64 tvOSSim x64 |
src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewAccessor.Tests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewStream.Tests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs
Outdated
Show resolved
Hide resolved
9/1 CI Completion After having 8x the trampoline settings Android has for iOS/MacCatalyst/tvOS which was already above the defaults, its hard to see what trampoline bump would be reasonable for iOS/MacCatalyst/tvOS. Its not clear what exactly is limiting from the trampolines that causes these suite failures, so this PR will now skip the test suites.Crashed SuitesAndroid x64 - NONE Android x86 - NONE iOSSim arm64
iOSSim x64
MacCatalyst arm64
MacCatalyst x64
tvOSSim x64
Test FailuresAndroid x64 - NONE Android x86 - NON iOSSim arm64 - NONE iOSSim x64 - NONE MacCatalyst arm64 - NONE MacCatalyst x64 - NONE tvOSSim x64 - NONE |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1215141145 |
@mdh1418 backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: [MacCatalyst][Libraries] Reenable MacCatalyst x64 crashing test suites
Applying: [MacCatalyst][Libraries] Reenable MacCatalyst arm64 crashing test suites
error: sha1 information is lacking or useless (src/libraries/tests.proj).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 [MacCatalyst][Libraries] Reenable MacCatalyst arm64 crashing test suites
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
…t and test fixes for Android (#58841) Manual backport of #57208, #58519, #58562, #58210, #57732, #58428, #58586, #58745, #57687 to release/6.0 Numerous test suites have been failing for iOS/tvOS/MacCatalyst consistently on CI without useful logs as to why. Moreover, some of these suites pass locally. This PR looks to reduce the failures on CI by skipping the problematic suites Skips test suites logged in #53624 ActiveIssues #58440 #58418 #58367 #58584 Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Jo Shields <directhex@apebox.org>
Numerous test suites have been failing for iOS/tvOS/MacCatalyst consistently on CI without useful logs as to why. Moreover, some of these suites pass locally.
This PR looks to reduce the failures on CI by skipping the problematic suites
Skips test suites logged in #53624
ActiveIssues
#58440
#58418
#58367
#58584