[libraries] Fix System.Runtime.Tests TimeZoneInfoTests for iOS/MacCatalyst/tvOS #57732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
MaximLipnin
approved these changes
Aug 19, 2021
|
The explicit Otherwise LGTM. |
This was referenced Aug 31, 2021
mdh1418
added a commit
to mdh1418/runtime
that referenced
this pull request
Sep 9, 2021
…alyst/tvOS (dotnet#57732) * [libraries] Fix System.Runtime.Tests TimeZoneInfoTests for iOS/MacCatalyst/tvOS * Remove redundant PlatformDetection.IsMacCatalyst as IsiOS covers it Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
steveisok
pushed a commit
that referenced
this pull request
Sep 13, 2021
…t and test fixes for Android (#58841) Manual backport of #57208, #58519, #58562, #58210, #57732, #58428, #58586, #58745, #57687 to release/6.0 Numerous test suites have been failing for iOS/tvOS/MacCatalyst consistently on CI without useful logs as to why. Moreover, some of these suites pass locally. This PR looks to reduce the failures on CI by skipping the problematic suites Skips test suites logged in #53624 ActiveIssues #58440 #58418 #58367 #58584 Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Jo Shields <directhex@apebox.org>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52072
WindowsIds such as
"Pacific Standard Time"are not valid TimeZoneIds on iOS/MacCatalyst/tvOS.iOS and tvOS both use
TimeZoneInfo.MinimalGlobalizationData.csand soTryConvertIanaIdToWindowsIdandTryConvertWindowsIdToIanaIdwill always return false.This PR looks to skip TimeZoneInfoTests that test windows TimeZoneIds and modifies tests to use iOS/MacCatalyst/tvOS friendly TimeZoneIds instead.