Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1293280 #57384

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

dotnet-bot
Copy link
Collaborator

No description provided.

@ghost
Copy link

ghost commented Aug 13, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: dotnet-bot
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@eiriktsarpalis
Copy link
Member

Seeing quite a few of these PRs being filed today:

#57386
#57390
#57393

@danmoseley do they require review from somebody or do we just merge away?

@danmoseley
Copy link
Member

I have no idea what these are. I would wait for @ericstj input on Monday. We don't localize but he may have context.

@ViktorHofer
Copy link
Member

I have no idea what these are. I would wait for @ericstj input on Monday. We don't localize but he may have context.

The source generator (what's being touched in this PR) is localized and we ship its satellite assemblies as part of the shared framework.

@ericstj
Copy link
Member

ericstj commented Aug 16, 2021

We should make sure relevant tests are green before merging. Sometimes tests may have assertions that are dependent on localized strings, which could get broken during localization. Other than that, you don't need to review for actual content.

@ericstj
Copy link
Member

ericstj commented Aug 16, 2021

Test failure is #57221

@ericstj ericstj merged commit a7e741b into main Aug 16, 2021
This was referenced Aug 16, 2021
thaystg added a commit to thaystg/runtime that referenced this pull request Aug 16, 2021
…information

# By dotnet-maestro[bot] (4) and others
# Via GitHub
* origin/main: (58 commits)
  Localized file check-in by OneLocBuild Task (dotnet#57384)
  [debugger][wasm] Support DebuggerProxyAttribute (dotnet#56872)
  Account for type mismatch of `FIELD_LIST` members in LSRA (dotnet#57450)
  Qualify `sorted_table` allocation with `nothrow` (dotnet#57467)
  Rename transport packages to follow convention (dotnet#57504)
  Generate proper DWARF reg num for ARM32 (dotnet#57443)
  Enable System.Linq.Queryable and disable dotnet#50712 (dotnet#57464)
  Mark individual tests for 51211 (dotnet#57463)
  Fix Length for ReadOnlySequence created out of sliced Memory owned by MemoryManager (dotnet#57479)
  Add JsonConverter.Write/ReadAsPropertyName APIs (dotnet#57302)
  Remove workaround for dotnet/sdk#19482 (dotnet#57453)
  Do not drain HttpContentReadStream if the connection is disposed (dotnet#57287)
  [mono] Fix a few corner case overflow operations (dotnet#57407)
  make use of ports in SPN optional (dotnet#57159)
  Fixed H/3 stress server after the last Kestrel change (dotnet#57356)
  disable a failing stress test. (dotnet#57473)
  Eliminate temporary byte array allocations in the static constructor of `IPAddress`. (dotnet#57397)
  Update dependencies from https://github.com/dotnet/emsdk build 20210815.1 (dotnet#57447)
  [main] Update dependencies from mono/linker (dotnet#57344)
  Improve serializer performance (dotnet#57327)
  ...

# Conflicts:
#	src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
#	src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
#	src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
@danmoseley danmoseley deleted the locfiles/03597464-cd1f-4e64-97ab-62bfc818e753 branch August 16, 2021 23:29
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants