Fix Microsoft.NETCore.Platforms builds on Unix #57739
Conversation
The casing of the SDK imported via the Sdk attribute was wrong which lead to: Microsoft.NETCore.Platforms.csproj : error MSB4236: The SDK 'Microsoft.NET.SDK' specified could not be found.
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsFixes #57702 The casing of the SDK imported via the Sdk attribute was wrong which lead to:
We should probably backport this into release/6.0-rc1.
|
|
I believe this didn't fail in the Linux allconfigurations build because this only repros when directly restoring the project. If it's restored as part of a dependency in the build graph, it doesn't complain. |
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.SDK"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
I think it would had made more sense for SDK resolver to keep names case insensitive (i doubt it would break anything since changing just the casing and publishing a different SDK to nuget.org doesn't work anyway), and especially since there are legit SDKs available with capital casing, e.g. Microsoft.NET.SDK.WorkloadAutoImportPropsLocator, Microsoft.NET.SDK.WorkloadManifestTargetsLocator; it's very easy to make this mistake. 😅
|
/backport to release/6.0-rc1 |
|
Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1148096995 |
ghost
locked as resolved and limited conversation to collaborators
Fixes #57702
The casing of the SDK imported via the Sdk attribute was wrong which lead to:
Microsoft.NETCore.Platforms.csproj : error MSB4236: The SDK 'Microsoft.NET.SDK' specified could not be found.We should probably backport this into release/6.0-rc1.