Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-rc1] Fix Microsoft.NETCore.Platforms builds on Unix #57757

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #57739 to release/6.0-rc1

/cc @ViktorHofer

Customer Impact

Testing

Risk

The casing of the SDK imported via the Sdk attribute was wrong which lead to:

Microsoft.NETCore.Platforms.csproj : error MSB4236: The SDK 'Microsoft.NET.SDK' specified could not be found.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 19, 2021

@ericstj again I believe this should be treated as a tell-mode only change. It blocks servicing (updating RID groups) and hence needs to be ported into release/6.0.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yes we need for RC1

@ViktorHofer ViktorHofer merged commit 86b25c6 into release/6.0-rc1 Aug 19, 2021
@ViktorHofer ViktorHofer deleted the backport/pr-57739-to-release/6.0-rc1 branch August 19, 2021 22:50
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants