-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: fix interaction of GDV and boxing #60355
JIT: fix interaction of GDV and boxing #60355
Conversation
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIn #56126 we disabled GDV if the object being boxed came from a call with a Fix this and enable GDV for these cases by inserting the box allocation before
|
@EgorBo PTAL Quite a few diffs as we're changing the placement of a newobj call. Sometimes doing it earlier is better, sometimes it is not. Overall something of a wash. aspnet.run.windows.x64.checked.mch:
Detail diffs
benchmarks.run.windows.x64.checked.mch:
Detail diffs
coreclr_tests.pmi.windows.x64.checked.mch:
Detail diffs
libraries.crossgen2.windows.x64.checked.mch:
Detail diffs
libraries.pmi.windows.x64.checked.mch:
Detail diffs
libraries_tests.pmi.windows.x64.checked.mch:
Detail diffs
|
/azp run runtime-coreclr libraries-pgo |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr pgo |
Azure Pipelines successfully started running 1 pipeline(s). |
Seeing some failures like:
so this will need some more work. |
In dotnet#56126 we disabled GDV if the object being boxed came from a call with a hidden return buffer pointer. Fix this and enable GDV for these cases by inserting the box allocation before the call.
The issue is that in some cases, when generating the box newobj we actually create several statements, so all of them need to move as a group. |
794f1d3
to
24f65b1
Compare
/azp run runtime-coreclr libraries-pgo |
Azure Pipelines successfully started running 1 pipeline(s). |
Updated diffs aspnet.run.windows.x64.checked.mch:
Detail diffs
benchmarks.run.windows.x64.checked.mch:
Detail diffs
coreclr_tests.pmi.windows.x64.checked.mch:
Detail diffs
libraries.crossgen2.windows.x64.checked.mch:
Detail diffs
libraries.pmi.windows.x64.checked.mch:
Detail diffs
libraries_tests.pmi.windows.x64.checked.mch:
Detail diffs
|
I am seeing jit asserts in the dll import generator tests on Arm64 (which are new: #59579)
Not sure if this is a PGO specific failure yet. |
Other than the failure above (which I suspect is unrelated) I think this is ready to go. @EgorBo PTAL |
dll import generator arm64 test runs are also failing in jitstress, eg https://dev.azure.com/dnceng/public/_build/results?buildId=1429275&view=ms.vss-test-web.build-test-results-tab So it looks like these failures are more widespread. |
Opened #60624 for these new failures. |
In #56126 we disabled GDV if the object being boxed came from a call with a
hidden return buffer pointer.
Fix this and enable GDV for these cases by inserting the box allocation before
the call.