Fix Equals overload logic for some methods of an array created using MLC #60894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @buyaa-n Issue DetailsFixes #57728
|
steveharter
reviewed
Oct 27, 2021
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs
Show resolved
Hide resolved
steveharter
reviewed
Oct 28, 2021
| @@ -75,6 +75,9 @@ public sealed override bool Equals([NotNullWhen(true)] object? obj) | |||
| if (DeclaringType != other.DeclaringType) | |||
There was a problem hiding this comment.
For the current code, is DeclaringType always the same for every RoSyntheticMethod? It should be RoArrayType. In any case, comparing Declaring type as-is makes sense if RoSyntheticMethod is ever used outside of arrays.
There was a problem hiding this comment.
Yes DeclaringType is always same for every RoSyntheticMethod, need to check it as-is for different array types like int[] vs long[]
steveharter
approved these changes
Oct 28, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57728
Update Equals overload for RoMethods created by MetadataLoadContext to check
ReturnTypeinstead ofDeclaringType