Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Equals overload logic for some methods of an array created using MLC #60894

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Fix Equals overload logic for some methods of an array created using MLC #60894

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8b1ef6
Fix Equals overload logic for some methods of an array created using MLC
buyaa-n Oct 26, 2021
32da4b8
Apply feedback
buyaa-n Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ection.MetadataLoadContext/src/System/Reflection/TypeLoading/Methods/RoSyntheticMethod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public sealed override bool Equals([NotNullWhen(true)] object? obj)
if (!(obj is RoSyntheticMethod other))
return false;

if (DeclaringType != other.DeclaringType)
if (ReturnType != other.ReturnType)
return false;

if (_uniquifier != other._uniquifier)
Expand Down
17 changes: 17 additions & 0 deletions src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,23 @@ public static void TestArraySetMethod()
return;
}

[Fact]
static void TestArrayMethodsGetSetAddressAreNotEquals()
{
void test(Type type)
{
var v1 = type.GetMethod("Get");
var v2 = type.GetMethod("Set");
var v3 = type.GetMethod("Address");
Assert.NotEqual(v1, v2);
Assert.NotEqual(v1, v3);
Assert.NotEqual(v2, v3);
}

test(typeof(int[]));
test((typeof(int[])).Project());
}

buyaa-n marked this conversation as resolved.
Show resolved Hide resolved
[Fact]
public static void TestArrayAddressMethod()
{
Expand Down